Record type follow ups: #25218
Merged
Record type follow ups: #25218
+319
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
* Throw an error if a record type property has validation metadata * Disallow TryUpdateModel on a top-level record type * Ignore previously specified model value when binding a record type * Unskip record type tests * Clean up record type detection
pranavkm
force-pushed
the
prkrishn/record-types-followup
branch
from
0682f1b to
3e8a947
Compare
dougbu
reviewed
Aug 24, 2020
| @@ -137,37 +139,16 @@ internal IReadOnlyList<ModelMetadata> BoundProperties | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// A mapping from parameters to their corresponding properties on a record type. | |||
| /// </summary> | |||
There was a problem hiding this comment.
Nice to have doc comments for internal API given the complexities in this area❕
src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
Outdated
Show resolved
Hide resolved
src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
Show resolved
Hide resolved
JamesNK
reviewed
Aug 25, 2020
javiercn
approved these changes
Aug 25, 2020
Co-authored-by: James Newton-King <[email protected]>
pranavkm
commented
Aug 25, 2020
dougbu
approved these changes
Aug 25, 2020
Co-authored-by: Doug Bunting <[email protected]>
Co-authored-by: Doug Bunting <[email protected]>
pranavkm
commented
Aug 25, 2020
src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
Outdated
Show resolved
Hide resolved
src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
Outdated
Show resolved
Hide resolved
src/Mvc/test/Mvc.IntegrationTests/ValidationWithRecordIntegrationTests.cs
Outdated
Show resolved
Hide resolved
src/Mvc/test/Mvc.IntegrationTests/TryUpdateModelIntegrationTest.cs
Outdated
Show resolved
Hide resolved
JamesNK
approved these changes
Aug 25, 2020
|
@Pilchie could you merge this PR? |
|
Approved for RC1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24265