-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Use MonoProxy package for debugging #24721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4eed50d
to
9cc0f41
Compare
e066f70
to
5b9fb2f
Compare
5b9fb2f
to
9f6a58e
Compare
@dotnet/aspnet-blazor-eng This is not ready to merge because there are still some packaging issues with the BrowserDebugHost. However, the framework-side changes are ready fro review. |
<Dependency Name="Microsoft.NETCore.BrowserDebugHost.Transport" Version="6.0.0-dev"> | ||
<Uri>https://github.com/dotnet/runtime</Uri> | ||
<Sha>6cc7cffaff2e0413ee84d9a7736f9ae1aa9a3f12</Sha> | ||
</Dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a local change that bled into your PR❔ Version should match something actually coming out of the dotnet/runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still working on getting a working package out of the runtime repo. There's been quite a few hiccups so I ended up using a dev build to unblock myself.
I marked this PR as ready for review so that the framework-side changes can be reviewed. I won't be merging it until we have a working package and will update the versions accordingly then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's extremely pleasing to see our code get simplified and so much of it be removed :) Awesome!
I know this isn't ready for merge until some external updates flow in, but the framework parts of the changes look solid.
7323b74
to
ebba271
Compare
/fyi @captainsafia you can write a comment containing |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
911de1b
to
6f780bb
Compare
Approved for RC1. |
MS.NETCore.BrowserDebugHost.Transport
packageUseWebAssemblyDebugging
middleware to passbrowser
query correctly to debuggersDevToolsHost
configurationScenarios validated