Skip to content

Use MonoProxy package for debugging #24721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Use MonoProxy package for debugging #24721

merged 4 commits into from
Aug 28, 2020

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Aug 9, 2020

  • Remove DebugProxy project
  • Add references to MS.NETCore.BrowserDebugHost.Transport package
  • Copy debugging proxy assemblies from package to Server project output
  • Update path to executable in DebugProxyLauncher
  • Update UseWebAssemblyDebugging middleware to pass browser query correctly to debuggers DevToolsHost configuration

Scenarios validated

  • In-browser debugging
  • Debugging from VS

@Pilchie Pilchie added the area-blazor Includes: Blazor, Razor Components label Aug 10, 2020
@captainsafia captainsafia changed the base branch from release/5.0-preview8 to master August 11, 2020 19:39
@captainsafia captainsafia force-pushed the safia/dbg-proxy branch 4 times, most recently from 4eed50d to 9cc0f41 Compare August 21, 2020 01:11
@captainsafia captainsafia force-pushed the safia/dbg-proxy branch 2 times, most recently from e066f70 to 5b9fb2f Compare August 23, 2020 04:47
@captainsafia captainsafia changed the base branch from master to release/5.0 August 23, 2020 04:47
@captainsafia captainsafia marked this pull request as ready for review August 24, 2020 18:37
@captainsafia
Copy link
Member Author

@dotnet/aspnet-blazor-eng This is not ready to merge because there are still some packaging issues with the BrowserDebugHost. However, the framework-side changes are ready fro review.

<Dependency Name="Microsoft.NETCore.BrowserDebugHost.Transport" Version="6.0.0-dev">
<Uri>https://github.com/dotnet/runtime</Uri>
<Sha>6cc7cffaff2e0413ee84d9a7736f9ae1aa9a3f12</Sha>
</Dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a local change that bled into your PR❔ Version should match something actually coming out of the dotnet/runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still working on getting a working package out of the runtime repo. There's been quite a few hiccups so I ended up using a dev build to unblock myself.

I marked this PR as ready for review so that the framework-side changes can be reviewed. I won't be merging it until we have a working package and will update the versions accordingly then.

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's extremely pleasing to see our code get simplified and so much of it be removed :) Awesome!

I know this isn't ready for merge until some external updates flow in, but the framework parts of the changes look solid.

@captainsafia captainsafia force-pushed the safia/dbg-proxy branch 3 times, most recently from 7323b74 to ebba271 Compare August 26, 2020 21:43
@captainsafia captainsafia reopened this Aug 27, 2020
@captainsafia captainsafia reopened this Aug 27, 2020
@captainsafia captainsafia reopened this Aug 27, 2020
@dougbu
Copy link
Contributor

dougbu commented Aug 27, 2020

/fyi @captainsafia you can write a comment containing /azp run to get AzDO to do the same thing as closing and reopening the PR.

@captainsafia
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Aug 28, 2020
@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

Approved for RC1.

@mkArtakMSFT mkArtakMSFT merged commit 3db5c9c into release/5.0 Aug 28, 2020
@mkArtakMSFT mkArtakMSFT deleted the safia/dbg-proxy branch August 28, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants