Make GetFinalTransferCoding "safe" #21202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
ghost
added
the
Tornhoof
reviewed
Apr 25, 2020
gfoidl
reviewed
Apr 25, 2020
| const ulong lowerCaseULong = 0x0020_0020_0020_0020; | ||
| const uint lowerCaseUInt = 0x0020_0020; | ||
|
|
||
| const ulong hunkChars = 0x006b_006e_0075_0068; // 4 chars "hunk" |
There was a problem hiding this comment.
These are "funny" names 😉
What about chunkRemainderChars or that like, so that it's not that obscure to read if you're not in the mental context of the method?
I thought the same in #21004
|
|
||
| var byteValue = MemoryMarshal.AsBytes(value); | ||
|
|
||
| if ((c | lowerCaseChar) == 'c' && |
There was a problem hiding this comment.
I see this (good) pattern repeated several times (also in the other PRs).
Maybe this can be refactored with the struct-trick (I'm sure you get the idea)
But I don't know if this is a win code-wise. The constants (see comment above) could be wrapped in more obvious names that way and the logic re-used.
Together with a potential SIMD-approach (if it's worth it) the code would get cleaner.
Perf-wise it should result in the same.
benaadams
force-pushed
the
GetFinalTransferCoding
branch
from
b78ca3d to
480fe06
Compare
benaadams
force-pushed
the
GetFinalTransferCoding
branch
from
480fe06 to
67588d5
Compare
halter73
approved these changes
Apr 28, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To @blowdart with ❤
Contributes to #4720