OpenAPI Flaky fix #20383
Merged
OpenAPI Flaky fix #20383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-commandlinetools
|
👀 |
mkArtakMSFT
approved these changes
Mar 31, 2020
|
I assume @jkotalik didn't yet got chance to quarantine this? |
|
Yeah, didn't make the PR to quarantine this yet as I wanted Ryan to take a look before making the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test flaked on what was probably a networking/server problem. Considering that it is not specifically a test of the network section of code (we have one of those) I figured we might as well mock out the request as we have for other scenarios.
@mkArtakMSFT