Skip to content

Quarantine some tests #19932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Quarantine some tests #19932

merged 2 commits into from
Mar 17, 2020

Conversation

BrennanConroy
Copy link
Member

No description provided.

@analogrelay
Copy link
Contributor

Oh hey, you already started quarantining some tests ;). See my email with a few other things to throw in the box.

@BrennanConroy
Copy link
Member Author

See my email with a few other things to throw in the box

I think most of those other ones just came in after this PR :P

@BrennanConroy BrennanConroy merged commit 9112030 into master Mar 17, 2020
@BrennanConroy BrennanConroy deleted the brecon/quar branch March 17, 2020 23:31
@@ -184,7 +185,8 @@ public async Task SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBein
}

[Fact]
public async Task IfValidateAuthenticationStateAsyncReturnsUnrelatedCancelledTask_TreatAsFailure()
[QuarantinedTest]
public async Task IfValidateAuthenticationStateAsyncReturnsUnrelatedCanceledTask_TreatAsFailure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this flaky test while working on #10759 and have created an issue for it under #19940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants