Skip to content

Commit 9112030

Browse files
Quarantine some tests (#19932)
1 parent ae192af commit 9112030

File tree

6 files changed

+16
-11
lines changed

6 files changed

+16
-11
lines changed

src/Components/Server/test/Circuits/RevalidatingServerAuthenticationStateProvider.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
using System.Threading.Tasks;
1010
using Microsoft.AspNetCore.Components.Authorization;
1111
using Microsoft.AspNetCore.Components.Server;
12+
using Microsoft.AspNetCore.Testing;
1213
using Microsoft.Extensions.Logging.Abstractions;
1314
using Xunit;
1415

@@ -184,7 +185,8 @@ public async Task SuppliesCancellationTokenThatSignalsWhenRevalidationLoopIsBein
184185
}
185186

186187
[Fact]
187-
public async Task IfValidateAuthenticationStateAsyncReturnsUnrelatedCancelledTask_TreatAsFailure()
188+
[QuarantinedTest]
189+
public async Task IfValidateAuthenticationStateAsyncReturnsUnrelatedCanceledTask_TreatAsFailure()
188190
{
189191
// Arrange
190192
var validationTcs = new TaskCompletionSource<bool>();
@@ -200,11 +202,11 @@ public async Task IfValidateAuthenticationStateAsyncReturnsUnrelatedCancelledTas
200202
var firstRevalidationCall = provider.RevalidationCallLog.Single();
201203
Assert.Equal(0, authenticationStateChangedCount);
202204

203-
// Act: ValidateAuthenticationStateAsync returns cancelled task, but the cancellation
205+
// Act: ValidateAuthenticationStateAsync returns canceled task, but the cancellation
204206
// is unrelated to the CT we supplied
205207
validationTcs.TrySetCanceled(new CancellationTokenSource().Token);
206208

207-
// Assert: Since we didn't ask for that operation to be cancelled, this is treated as
209+
// Assert: Since we didn't ask for that operation to be canceled, this is treated as
208210
// a failure to validate, so we force a logout
209211
Assert.Equal(1, authenticationStateChangedCount);
210212
var newAuthState = await provider.GetAuthenticationStateAsync();

src/HealthChecks/HealthChecks/test/HealthCheckPublisherHostedServiceTest.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public async Task StopAsync_CancelsExecution()
129129
};
130130

131131
var service = CreateService(publishers);
132-
132+
133133
try
134134
{
135135
await service.StartAsync();
@@ -214,7 +214,7 @@ public async Task RunAsync_WaitsForCompletion_Single()
214214
entry => { Assert.Contains(entry.EventId, new[] { DefaultHealthCheckService.EventIds.HealthCheckBegin, DefaultHealthCheckService.EventIds.HealthCheckEnd }); },
215215
entry => { Assert.Contains(entry.EventId, new[] { DefaultHealthCheckService.EventIds.HealthCheckBegin, DefaultHealthCheckService.EventIds.HealthCheckEnd }); },
216216
entry => { Assert.Equal(DefaultHealthCheckService.EventIds.HealthCheckEnd, entry.EventId); },
217-
entry => { Assert.Equal(DefaultHealthCheckService.EventIds.HealthCheckProcessingEnd, entry.EventId); },
217+
entry => { Assert.Equal(DefaultHealthCheckService.EventIds.HealthCheckProcessingEnd, entry.EventId); },
218218
entry => { Assert.Equal(HealthCheckPublisherHostedService.EventIds.HealthCheckPublisherBegin, entry.EventId); },
219219
entry => { Assert.Equal(HealthCheckPublisherHostedService.EventIds.HealthCheckPublisherEnd, entry.EventId); },
220220
entry => { Assert.Equal(HealthCheckPublisherHostedService.EventIds.HealthCheckPublisherProcessingEnd, entry.EventId); });
@@ -274,6 +274,7 @@ public async Task RunAsync_WaitsForCompletion_Multiple()
274274
}
275275

276276
[Fact]
277+
[QuarantinedTest]
277278
public async Task RunAsync_PublishersCanTimeout()
278279
{
279280
// Arrange
@@ -440,7 +441,7 @@ public async Task RunAsync_HandlesExceptions_Multiple()
440441
}
441442

442443
private HealthCheckPublisherHostedService CreateService(
443-
IHealthCheckPublisher[] publishers,
444+
IHealthCheckPublisher[] publishers,
444445
Action<HealthCheckPublisherOptions> configure = null,
445446
TestSink sink = null)
446447
{

src/Mvc/Mvc.TagHelpers/test/CacheTagHelperTest.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -887,6 +887,7 @@ public async Task ProcessAsync_ThrowsExceptionForAwaiters_IfExecutorEncountersAn
887887
}
888888

889889
[Fact]
890+
[QuarantinedTest]
890891
public async Task ProcessAsync_AwaitersUseTheResultOfExecutor()
891892
{
892893
// Arrange

src/Servers/Kestrel/test/FunctionalTests/UnixDomainSocketsTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ public class UnixDomainSocketsTest : TestApplicationErrorLoggerLoggedTest
3030
#endif
3131
[ConditionalFact]
3232
[CollectDump]
33-
[QuarantinedTest]
3433
public async Task TestUnixDomainSocket()
3534
{
3635
var path = Path.GetTempFileName();

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3660,6 +3660,7 @@ await ExpectAsync(Http2FrameType.HEADERS,
36603660
[Theory]
36613661
[InlineData(true)]
36623662
[InlineData(false)]
3663+
[QuarantinedTest]
36633664
public async Task CONTINUATION_Received_WithTrailers_Available(bool sendData)
36643665
{
36653666
await InitializeConnectionAsync(_readTrailersApplication);

src/Tools/dotnet-user-secrets/test/SecretManagerTests.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,17 +197,18 @@ public void Remove_Non_Existing_Secret()
197197
}
198198

199199
[Fact]
200+
[QuarantinedTest]
200201
public void Remove_Is_Case_Insensitive()
201202
{
202203
var projectPath = _fixture.GetTempSecretProject();
203204
var secretManager = CreateProgram();
204-
secretManager.RunInternal("set", "SeCreT1", "value", "-p", projectPath);
205-
secretManager.RunInternal("list", "-p", projectPath);
205+
secretManager.RunInternal("set", "SeCreT1", "value", "-p", projectPath, "--verbose");
206+
secretManager.RunInternal("list", "-p", projectPath, "--verbose");
206207
Assert.Contains("SeCreT1 = value", _console.GetOutput());
207-
secretManager.RunInternal("remove", "secret1", "-p", projectPath);
208+
secretManager.RunInternal("remove", "secret1", "-p", projectPath, "--verbose");
208209

209210
_console.ClearOutput();
210-
secretManager.RunInternal("list", "-p", projectPath);
211+
secretManager.RunInternal("list", "-p", projectPath, "--verbose");
211212

212213
Assert.Contains(Resources.Error_No_Secrets_Found, _console.GetOutput());
213214
}

0 commit comments

Comments
 (0)