Skip to content

Add HTTP/2 pseudo headers as known headers #19457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 29, 2020
Merged

Add HTTP/2 pseudo headers as known headers #19457

merged 4 commits into from
Feb 29, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 28, 2020

Fixes #4761

@ghost ghost added the area-servers label Feb 28, 2020
Tratcher
Tratcher approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if this registers on the benchmarks.

@JamesNK JamesNK merged commit 41a3c63 into master Feb 29, 2020
@JamesNK JamesNK deleted the jamesnk/http2-pseudoheaders branch February 29, 2020 03:00
@analogrelay analogrelay added this to the 5.0.0-preview2 milestone Mar 2, 2020
@titanix
Copy link
Contributor

titanix commented Nov 1, 2020

There is a typo in variable name in https://github.com/dotnet/aspnetcore/blob/master/src/Servers/Kestrel/shared/KnownHeaders.cs#L369

var identifer instead of var identifier

@Tratcher
Copy link
Member

Tratcher commented Nov 2, 2020

Woops. Want to fix it?

@titanix titanix mentioned this pull request Nov 2, 2020
Merged
@titanix
Copy link
Contributor

titanix commented Nov 2, 2020

I made a PR. Note I just lexically change the source code from GitHub since I don't have enough storage on my machine to download, build and test code.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
5.0.0-preview2
Development

Successfully merging this pull request may close these issues.

Add HTTP/2 pseudo-headers as known headers
5 participants
@JamesNK @titanix @Tratcher @analogrelay @amcasey