Skip to content

Update precedence and Identity of templates for 5.0 #19248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2020
Merged

Update precedence and Identity of templates for 5.0 #19248

merged 1 commit into from
Feb 22, 2020

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes #17553.

@mkArtakMSFT I believe it was you who created the mapping for https://aka.ms/aspnetcore/5.0-third-party-notices last time? We need to do that again. This is basically a copy of https://github.com/dotnet/aspnetcore/pull/14637/files, plus the fact that we have a new template.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 21, 2020
mkArtakMSFT
mkArtakMSFT approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkArtakMSFT mkArtakMSFT added the Servicing-consider Shiproom approval is required for the issue label Feb 21, 2020
@ghost
Copy link

ghost commented Feb 21, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@mkArtakMSFT mkArtakMSFT added this to the 5.0.0-preview1 milestone Feb 21, 2020
@mkArtakMSFT mkArtakMSFT requested a review from phenning February 21, 2020 22:23
@dougbu
Copy link
Contributor

dougbu commented Feb 21, 2020

@ryanbrandenburg doesn't downstream packaging use the template names i.e. doesn't something else need to change to pick up the new "5.0" templates?

@wtgodbe
Copy link
Member

wtgodbe commented Feb 22, 2020

Are we taking this today, or will we have to wait for Monday?

CC @mmitche as this will effect the timeline for preview1

@vijayrkn
Copy link

Without this change, if 5.0 preview1 is installed, users wont be able to create 3.1 projects in VS.
So yes, we need to take it for preview1.

@phenning
Copy link
Contributor

@dougbu packaging is dependent on the package authoring not the individual template identities. I believe the package is currently being created properly.

@wtgodbe
Copy link
Member

wtgodbe commented Feb 22, 2020

Tactics approved this, merging

@wtgodbe wtgodbe added the Servicing-approved Shiproom has approved the issue label Feb 22, 2020
@ghost ghost removed the Servicing-consider Shiproom approval is required for the issue label Feb 22, 2020
@wtgodbe wtgodbe removed the Servicing-consider Shiproom approval is required for the issue label Feb 22, 2020
@wtgodbe wtgodbe merged commit 294b116 into release/5.0-preview1 Feb 22, 2020
@wtgodbe wtgodbe deleted the rybrande/TemplateUpdate branch February 22, 2020 01:28
mkArtakMSFT pushed a commit that referenced this pull request Feb 26, 2020
@ryanbrandenburg
Update precedence and Identity of templates for 5.0 (#19248)
e4dba69
mkArtakMSFT added a commit that referenced this pull request Feb 28, 2020
@mkArtakMSFT @ryanbrandenburg
Update precedence and Identity of templates for 5.0 (#19248) (#19377)
8338060 
Co-authored-by: Ryan Brandenburg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phenning phenning phenning approved these changes

@vijayrkn vijayrkn vijayrkn approved these changes

@ajaybhargavb ajaybhargavb Awaiting requested review from ajaybhargavb

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

+1 more reviewer

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
5.0.0-preview1
Development

Successfully merging this pull request may close these issues.
6 participants
@ryanbrandenburg @dougbu @wtgodbe @vijayrkn @phenning @mkArtakMSFT