Fix HttpResponseStreamWriter #19216
Merged
Fix HttpResponseStreamWriter #19216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
halter73
reviewed
Feb 21, 2020
| @@ -136,7 +136,7 @@ public override void Write(ReadOnlySpan<char> value) | |||
| } | |||
|
|
|||
| var written = 0; | |||
| while (written < value.Length) | |||
| while (true) | |||
There was a problem hiding this comment.
I like keeping the terminating condition in the loop condition. Right now, it looks like written should be cumulative since it's defined outside of the loop, but really it's just that size of the last chunk that was written.
I would do var remaining = value.length; instead of var written = 0;, and then make while (remaining > 0) the loop condition. Then you can just put remaining -= written after var written = CopyToCharBuffer(value); and keep everything else the same as it was. I think that makes it much easier to see what's going on.
halter73
reviewed
Feb 21, 2020
| @@ -290,7 +292,6 @@ private async Task WriteAsyncAwaited(string value) | |||
| var count = value.Length; | |||
|
|
|||
| Debug.Assert(count > 0); | |||
| Debug.Assert(_charBufferSize - _charBufferCount < count); | |||
There was a problem hiding this comment.
We can keep this assert now, right?
halter73
approved these changes
Feb 21, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18972. There was also another Debug.Assert being fired every time, so I changed WriteAsyncAwaited to WriteAsync to keep the invariant in tact.