Skip to content

Conversation

jkotalik
Copy link
Contributor

Fixes #13108. This is an infrastructure change, so this may fall under tell mode. @anurse ?

@jkotalik jkotalik added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Aug 14, 2019
@jkotalik jkotalik requested review from analogrelay, dsplaisted and a team August 14, 2019 16:08
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@jkotalik jkotalik added the tell-mode Indicates a PR which is being merged during tell-mode label Aug 14, 2019
@jkotalik
Copy link
Contributor Author

Slapping tell mode on this for now, @dsplaisted @anurse if this deserves an ask mode label, I'll adjust and add the template.

@dsplaisted
Copy link
Member

dsplaisted commented Aug 14, 2019

@jkotalik As far as I know this should go through ask mode.

EDIT: I guess if you consider this an infrastructure change, it could be tell mode.

@analogrelay
Copy link
Contributor

Doesn't hurt to run it through the process. I'll send an email.

@jkotalik jkotalik added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Aug 14, 2019
@analogrelay analogrelay removed the tell-mode Indicates a PR which is being merged during tell-mode label Aug 14, 2019
@jkotalik
Copy link
Contributor Author

I believe this was approved. @anurse you may do the honors.

@analogrelay analogrelay merged commit 417cba2 into release/3.0 Aug 15, 2019
@analogrelay analogrelay deleted the jkotalik/platformName branch August 15, 2019 15:48
@analogrelay
Copy link
Contributor

I concur with your assessment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants