Fix globalization for @bind-value
#12654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
requested review from
pranavkm,
SteveSandersonMS,
JunTaoLuo and
javiercn
rynowak
force-pushed
the
rynowak/fix-bind-value-globalization
branch
from
a708f13 to
d328b06
Compare
src/Components/Blazor/Build/src/Microsoft.AspNetCore.Blazor.Build.csproj
Outdated
Show resolved
Hide resolved
rynowak
force-pushed
the
rynowak/fix-bind-value-globalization
branch
from
d328b06 to
58e5612
Compare
Fixes: #12631 These mappings were missing and adding them restores the correct behaviour. Mixing up the usage of `@bind` vs `@bind-value` so we have more coverage of this.
rynowak
force-pushed
the
rynowak/fix-bind-value-globalization
branch
from
58e5612 to
d517fa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12631
These mappings were missing and adding them restores the correct
behaviour. Mixing up the usage of
@Bindvs@bind-valueso we havemore coverage of this.