Skip to content

Commit a708f13

Browse files
author
Ryan Nowak
committed
Fix globalization for @bind-value
Fixes: #12631 These mappings were missing and adding them restores the correct behaviour. Mixing up the usage of `@bind` vs `@bind-value` so we have more coverage of this.
1 parent 627bd69 commit a708f13

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

src/Components/Web/src/BindAttributes.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ namespace Microsoft.AspNetCore.Components
2424

2525
// type="number" is invariant culture
2626
[BindInputElement("number", null, "value", "onchange", isInvariantCulture: true, format: null)]
27+
[BindInputElement("number", "value", "value", "onchange", isInvariantCulture: true, format: null)]
2728

2829
// type="date" is invariant culture with a specific format
2930
[BindInputElement("date", null, "value", "onchange", isInvariantCulture: true, format: "yyyy-MM-dd")]
31+
[BindInputElement("date", "value", "value", "onchange", isInvariantCulture: true, format: "yyyy-MM-dd")]
3032

3133
[BindElement("select", null, "value", "onchange")]
3234
[BindElement("textarea", null, "value", "onchange")]

src/Components/test/testassets/BasicTestApp/BindCasesComponent.razor

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
</p>
3333
<p>
3434
Nullable int:
35-
<input id="textbox-nullable-int" @bind="textboxNullableIntValue" type="number" />
35+
<input id="textbox-nullable-int" @bind-value="textboxNullableIntValue" type="number" />
3636
<span id="textbox-nullable-int-value">@textboxNullableIntValue</span>
3737
<input id="textbox-nullable-int-mirror" @bind="textboxNullableIntValue" readonly />
3838
</p>
@@ -50,7 +50,7 @@
5050
</p>
5151
<p>
5252
float:
53-
<input id="textbox-float" @bind="textboxFloatValue" type="number" />
53+
<input id="textbox-float" @bind-value="textboxFloatValue" type="number" />
5454
<span id="textbox-float-value">@textboxFloatValue</span>
5555
<input id="textbox-float-mirror" @bind="textboxFloatValue" readonly />
5656
</p>
@@ -74,7 +74,7 @@
7474
</p>
7575
<p>
7676
decimal:
77-
<input id="textbox-decimal" @bind="textboxDecimalValue" type="number" />
77+
<input id="textbox-decimal" @bind-value="textboxDecimalValue" type="number" />
7878
<span id="textbox-decimal-value">@textboxDecimalValue</span>
7979
<input id="textbox-decimal-mirror" @bind="textboxDecimalValue" readonly />
8080
</p>
@@ -119,7 +119,7 @@
119119
</p>
120120
<p>
121121
Nullable DateTime:
122-
<input id="textbox-nullable-datetime" @bind="textboxNullableDateTimeValue" type="text" />
122+
<input id="textbox-nullable-datetime" @bind-value="textboxNullableDateTimeValue" type="text" />
123123
<span id="textbox-nullable-datetime-value">@textboxNullableDateTimeValue</span>
124124
<input id="textbox-nullable-datetime-mirror" @bind="textboxNullableDateTimeValue" readonly />
125125
</p>
@@ -149,7 +149,7 @@
149149
</p>
150150
<p>
151151
DateTime (format):
152-
<input id="textbox-datetime-format" @bind="textboxDateTimeFormatValue" type="text" @bind:format="MM-dd" />
152+
<input id="textbox-datetime-format" @bind-value="textboxDateTimeFormatValue" type="text" @bind-value:format="MM-dd" />
153153
<span id="textbox-datetime-format-value">@textboxDateTimeFormatValue</span>
154154
<input id="textbox-datetime-format-mirror" @bind="textboxDateTimeFormatValue" readonly />
155155
</p>
@@ -161,7 +161,7 @@
161161
</p>
162162
<p>
163163
DateTime (format / invalid value):
164-
<input id="textbox-datetime-format-invalid" @bind="textboxDateTimeFormatInvalidValue" type="text" @bind:format="MM-dd" />
164+
<input id="textbox-datetime-format-invalid" @bind-value="textboxDateTimeFormatInvalidValue" type="text" @bind-value:format="MM-dd" />
165165
<span id="textbox-datetime-format-invalid-value">@textboxDateTimeFormatInvalidValue</span>
166166
<input id="textbox-datetime-format-invalid-mirror" @bind="textboxDateTimeFormatInvalidValue" readonly />
167167
</p>

src/Components/test/testassets/BasicTestApp/GlobalizationBindCases.razor

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<span id="input_type_text_int_value">@inputTypeTextInt</span>
1111
</div>
1212
<div>
13-
decimal: <input type="text" id="input_type_text_decimal" @bind="inputTypeTextDecimal" />
13+
decimal: <input type="text" id="input_type_text_decimal" @bind-value="inputTypeTextDecimal" />
1414
<span id="input_type_text_decimal_value">@inputTypeTextDecimal</span>
1515
</div>
1616
</div>
@@ -22,7 +22,7 @@
2222
<span id="input_type_text_datetime_value">@inputTypeTextDateTime</span>
2323
</div>
2424
<div>
25-
DateTimeOffset: <input type="text" id="input_type_text_datetimeoffset" @bind="inputTypeTextDateTimeOffset" />
25+
DateTimeOffset: <input type="text" id="input_type_text_datetimeoffset" @bind-value="inputTypeTextDateTimeOffset" />
2626
<span id="input_type_text_datetimeoffset_value">@inputTypeTextDateTimeOffset</span>
2727
</div>
2828
</div>
@@ -34,7 +34,7 @@
3434
<span id="input_type_number_int_value">@inputTypeNumberInt</span>
3535
</div>
3636
<div>
37-
decimal: <input type="number" id="input_type_number_decimal" @bind="inputTypeNumberDecimal" />
37+
decimal: <input type="number" id="input_type_number_decimal" @bind-value="inputTypeNumberDecimal" />
3838
<span id="input_type_number_decimal_value">@inputTypeNumberDecimal</span>
3939
</div>
4040
</div>
@@ -47,7 +47,7 @@
4747
<span id="input_type_date_datetime_value">@inputTypeDateDateTime</span>
4848
</div>
4949
<div>
50-
DateTimeOffset: <input type="text" id="input_type_date_datetimeoffset_extrainput" @bind="inputTypeDateDateTimeOffset" />
50+
DateTimeOffset: <input type="text" id="input_type_date_datetimeoffset_extrainput" @bind-value="inputTypeDateDateTimeOffset" />
5151
<input type="date" id="input_type_date_datetimeoffset" @bind="inputTypeDateDateTimeOffset" />
5252
<span id="input_type_date_datetimeoffset_value">@inputTypeDateDateTimeOffset</span>
5353
</div>

0 commit comments

Comments
 (0)