Skip to content

Conversation

@jkotalik
Copy link
Contributor

Should be the same change for release/2.2

@jkotalik jkotalik requested a review from analogrelay July 17, 2019 22:13
@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 18, 2019
@analogrelay analogrelay added this to the 2.2.x milestone Jul 18, 2019
@jkotalik
Copy link
Contributor Author

@anurse can you merge this?

@analogrelay
Copy link
Contributor

Can you cite the original 2.1 PR and give an review approval (I actually do need that to merge on these branches ;))?

@jkotalik
Copy link
Contributor Author

I can't review my own PR... here is my original PR: #11616

@jkotalik
Copy link
Contributor Author

I didn't actually verify this on aspnetci yet. If you'd prefer I do that, I can, but I believe it should be exactly the same change.

@analogrelay
Copy link
Contributor

I can't review my own PR

Lol. Ok, I can override it.

@analogrelay
Copy link
Contributor

Merging as this is infrastructure only and the change was previously approved for 2.1

@analogrelay analogrelay merged commit 9a6d4af into release/2.2 Jul 25, 2019
@analogrelay analogrelay modified the milestones: 2.2.x, 2.2.7 Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants