DataProtection: Refresh key rings for a short window #11987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabYourPitchforks
approved these changes
Jul 9, 2019
Member
GrabYourPitchforks
left a comment
GrabYourPitchforks
left a comment
There was a problem hiding this comment.
LGTM, per our email thread.
ghost
deleted the
amcasey
added a commit
to amcasey/aspnetcore
that referenced
this pull request
Mar 19, 2024
During the auto-refresh window, an `Unprotect` call with an unknown key ID is allowed to bypass the cache and perform a fresh read of the key ring (dotnet#11987). While, in principle, "force" means that it must happen every time, in practice, it doesn't make sense to block until an ongoing refresh is finished and then immediately perform another one. Instead, wait for the in-progress refresh to complete and return the same value (or throw, as appropriate). Preserving the precise exception from the thread that actually does the refresh didn't seem important, so I didn't bother (for now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3975
Note: Hard coded 5 minute window for now