TestServer Reset support, fix up Abort #11812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
changed the title
JamesNK
reviewed
Jul 2, 2019
halter73
reviewed
Jul 3, 2019
halter73
approved these changes
Jul 3, 2019
JamesNK
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11598 Implemented the response reset feature to throw a custom exception to the client with the reset error code.
I had intended this to mirror the normal Abort logic, but I found out that Abort hadn't been fully implemented yet. Abort would fire RequestAborted, but it wouldn't notify the client. Now it throws on the client.
Will follow-up with a CompleteAsync implementation.