Skip to content

Conversation

JunTaoLuo
Copy link
Contributor

Addresses #3752

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 30, 2019
@JunTaoLuo JunTaoLuo force-pushed the johluo/sourc-build branch 2 times, most recently from e8965f2 to 94a9fd5 Compare July 2, 2019 18:55
@JunTaoLuo JunTaoLuo force-pushed the johluo/sourc-build branch from a01b887 to 6f8d9ba Compare July 3, 2019 00:59
This should be excluded already, and is already excluded locally not sure why it's being built on the CI
@JunTaoLuo JunTaoLuo force-pushed the johluo/sourc-build branch from f7893c7 to a34d389 Compare July 3, 2019 01:47
@JunTaoLuo JunTaoLuo force-pushed the johluo/sourc-build branch from 4ccf194 to 42912c3 Compare July 5, 2019 21:49
@JunTaoLuo JunTaoLuo marked this pull request as ready for review July 5, 2019 22:09
@JunTaoLuo JunTaoLuo requested a review from a team as a code owner July 5, 2019 22:09
@JunTaoLuo
Copy link
Contributor Author

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2771

John Luo and others added 2 commits July 5, 2019 20:28
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of outstanding points, including a few on earlier iterations

@JunTaoLuo JunTaoLuo merged commit e31813b into master Jul 8, 2019
@ghost ghost deleted the johluo/sourc-build branch July 8, 2019 18:02
@dougbu
Copy link
Contributor

dougbu commented Jul 8, 2019

Hurray:grey_exclamation:

@sharpninja
Copy link

What is the expected happy path for building the repository from scratch on Ubuntu 18.04 in WSL 2? I'm using this script:

#!/usr/bin/env bash

cd /mnt/e/GitHub/sharpninja

rm -r -f aspnetcore

git clone --recursive [email protected]:sharpninja/AspNetCore.git

git submodule update --init --recursive

cd aspnetcore

git remote add upstream https://github.com/aspnet/aspnetcore
git fetch upstream
git merge upstream/master

./restore.sh
./build.sh --all --restore -c Debug -v d

Unfortunately, it attempts to import internal.aspnetcore.buildtasks/3.0.0-build-20190530.3 twice and bombs out on the second attempt. I'm attaching a log file.
aspnet-build.log

@dougbu
Copy link
Contributor

dougbu commented Aug 7, 2019

@sharpninja it sounds like you're having an issue with building this repo locally. If that's the case, commenting on a merged PR is not likely to get attention. Please file a new issue if my comments don't help.

Suggest leaving --restore out of the ./build.sh command. In addition, execute git submodule update --init --recursive much later, after updating your local 'master' branch and just before ./restore.sh.

In case your fork contains commits that are causing problems, I also suggest git reset --hard upstream/master instead of git merge upstream/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants