Skip to content

Register SystemTextJsonResultExecutor #11247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2019
Merged

Register SystemTextJsonResultExecutor #11247

merged 1 commit into from
Jun 17, 2019

Conversation

martincostello
Copy link
Member

Register SystemTextJsonResultExecutor as part of MVC core services so that JsonResult works without Newtonsoft.Json being registered via AddNewtonsoftJson().

I wasn't sure on the best approach to use for the tests, so I forked the existing JsonResultTest functional test into two as JsonResultWithNewtonsoftJsonTest and JsonResultWithSystemTextJsonTest.

Addresses #11246.

@martincostello
Register SystemTextJsonResultExecutor
3850aa6 
Register SystemTextJsonResultExecutor as part of MVC core services so that JsonResult works without Newtonsoft.Json.
Addresses dotnet#11246.
@analogrelay analogrelay requested a review from rynowak June 15, 2019 17:11
@analogrelay analogrelay added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 15, 2019
@analogrelay analogrelay requested a review from pranavkm June 15, 2019 17:11
@davidfowl davidfowl requested review from pranavkm and removed request for pranavkm June 15, 2019 17:30
pranavkm
pranavkm approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martincostello

@pranavkm pranavkm merged commit 87ea03d into dotnet:master Jun 17, 2019
@pranavkm pranavkm added this to the 3.0.0-preview7 milestone Jun 17, 2019
@martincostello martincostello deleted the Fix-11246 branch June 17, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynowak rynowak Awaiting requested review from rynowak

1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.
3 participants
@martincostello @pranavkm @analogrelay