Skip to content

Allow null arguments from HubConnection #11241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2019
Merged

Allow null arguments from HubConnection #11241

merged 1 commit into from
Jun 15, 2019

Conversation

BrennanConroy
Copy link
Member

Fixes #11239

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Jun 14, 2019
@BrennanConroy BrennanConroy added this to the 3.0.0-preview7 milestone Jun 14, 2019
@pranavkm
Copy link
Contributor

Does the Java client need to be fixed?

@BrennanConroy
Copy link
Member Author

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=225978&view=logs

@aspnet-hello
Copy link

This comment was made automatically. If there is a problem contact [email protected].

I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2489
https://github.com/aspnet/AspNetCore-Internal/issues/1979

@mikaelm12
Copy link
Contributor

Does the Java client need to be fixed?

https://github.com/aspnet/AspNetCore/blob/f652c222028ebd504203dce6a68e67b416465aab/src/SignalR/clients/java/signalr/src/main/java/com/microsoft/signalr/HubConnection.java#L582
instanceof works with null so I think it should be fine. I'll add a test though to be sure.

@BrennanConroy BrennanConroy merged commit 5872814 into master Jun 15, 2019
@BrennanConroy BrennanConroy deleted the brecon/fixNull branch June 15, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analogrelay analogrelay Awaiting requested review from analogrelay

@halter73 halter73 Awaiting requested review from halter73

2 more reviewers

@pranavkm pranavkm pranavkm approved these changes

@mikaelm12 mikaelm12 mikaelm12 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
3.0.0-preview7
Development

Successfully merging this pull request may close these issues.

Null ref in HubConnection if parameter is null
4 participants
@BrennanConroy @pranavkm @aspnet-hello @mikaelm12