Skip to content

Set official build ID #11077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Set official build ID #11077

merged 2 commits into from
Jun 11, 2019

Conversation

natemcmaster
Copy link
Contributor

Fix regression caused by #10674. Before this, CI picked up BUILD_BUILDNUMBER automatically from CI.

Arcade, on the other hand, requires that you explicitly set /p:OfficialBuildId=$(Build.BuildNumber) in order to get builds like 3.0.0-preview7.build.number

@natemcmaster natemcmaster requested a review from a team as a code owner June 11, 2019 04:27
@natemcmaster
Copy link
Contributor Author

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If internal test build works…

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jun 11, 2019
@natemcmaster natemcmaster merged commit 42f79ed into master Jun 11, 2019
@ghost ghost deleted the namc/signcheck branch June 11, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants