Deflaking a lot of tests #10960
Merged
Deflaking a lot of tests #10960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Jun 6, 2019
src/Hosting/Server.IntegrationTesting/src/Deployers/SelfHostDeployer.cs
Outdated
Show resolved
Hide resolved
Tratcher
reviewed
Jun 6, 2019
|
"Deflaking" is my favorite word. As is the phrase "a lot of tests". This PR is good PR. Nice PR. |
approve it then. |
|
I Approve.... OF this PR existing ;). It has many codes. |
analogrelay
reviewed
Jun 6, 2019
davidfowl
reviewed
Jun 7, 2019
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
|
Bleh, I think I introduced a hanging test with this. I'll investigate it. |
Oh that's my least favorite word. This is now bad PR. |
|
I'll fix the self-host deployer later. Something was causing a test to hang. Otherwise, 🆙 📅 |
BrennanConroy
approved these changes
Jun 11, 2019
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/FrebTests.cs
Outdated
Show resolved
Hide resolved
ghost
deleted the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2633
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2521
Adds extra logging for https://github.com/aspnet/AspNetCore-Internal/issues/2570
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/2568