Initialize eng/common/ folder from dotnet/arcade #10405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
May 20, 2019
dougbu
reviewed
May 20, 2019
| @@ -6,6 +6,7 @@ | |||
| /.config/ @aspnet/build | |||
| /build/ @aspnet/build | |||
| /eng/ @aspnet/build | |||
| /eng/common/ @dotnet-maestro-bot | |||
There was a problem hiding this comment.
Suggest including my, myself or I for the same reason I'm included on the next two lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7280 (Convert to Arcade SDK)
Arcade currently requires that you copy these 5,694 lines of code into your repo to use it.
Reviewers: there is no point in reviewing the contents of eng/common/ as we're supposed to mirror this code exactly from https://github.com/dotnet/arcade/. The only non eng/common/ change in this PR is an update to CODEOWNERS
cc @markwilkie