Improve TestServer support for Response.StartAsync #10189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
May 12, 2019
Tratcher
reviewed
May 13, 2019
There was a problem hiding this comment.
Yeah, that's right. OnStarting exceptions are considered fatal in all servers, but in Test Server we make a point of flowing any useful exception directly to the client so we can debug it.
That test was added after we found that pattern causing a deadlock with large data filling the pipe. It was real issue for the MVC tests. Feel free to clarify the naming but it's not wrong.
src/Middleware/Diagnostics/test/UnitTests/ExceptionHandlerTest.cs
Outdated
Show resolved
Hide resolved
Tratcher
approved these changes
May 13, 2019
ghost
deleted the
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8660
re: #8660 (comment)