mvc F# template: conditions defined in the templates are not correct

[vlada-shubina]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

mvc F# template: conditions defined in the templates are not correct.

I accidentally found out that conditions defined in F# mvc template are not correct.
Example of incorrect conditions:

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/Program.fs

Line 13 in 1e8fe7e

#if !NoHttps

aspnetcore/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/Program.fs

Line 39 in 1e8fe7e

#if HasHttpsProfile

F# files (same as C# files) use C++ condition evaluator, which requires the condition to be in brackets.
If the template is run in Debug mode, it will fall to exception.
In release mode, the condition is attempted to be evaluated anyway, and it works (likely accidentally), so it lowers the priority.

Conditions in C# files are correct.

Expected Behavior

Use #if (HasHttpsProfile) syntax for conditions in F# files, similar to C# files.

Steps To Reproduce

Run dotnet new mvc --language F# template in Debug mode of dotnet sdk.

Exceptions (if any)

No response

.NET Version

.NET 6, NET 7

Anything else?

No response

[rafikiassumani-msft]

@vlada-shubina We will be happy to accept a PR from you.

Hi @vlada-shubina. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[vlada-shubina]

@rafikiassumani-msft could you please clarify what is the question to me?

I'm not able to help you this week due to other commitments. The templates might stop working correctly if the issue is not fixed, as they are not using correct syntax.
As mentioned in the issue they already do not work in Debug configuration of dotnet/sdk and/or template engine.

[rafikiassumani-msft]

@vlada-shubina Would you like to submit a pull request to fix the F# template condition that you reported? We are not planning to invest time in F# templates due to low customer usage numbers.

Hi @vlada-shubina. We have added the "Needs: Author Feedback" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[vlada-shubina]

@rafikiassumani-msft we don't have capacity on the moment.

@mkArtakMSFT just fyi - F# templates are not using correct conditions and they already don't work on Debug configuration of SDK/template engine. There is a risk that they stop working in the future, as they don't use syntax that is officially supported.