Skip to content

Update WiX package dependency #36854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joeloff opened this issue Sep 22, 2021 · 9 comments
Closed

Update WiX package dependency #36854

joeloff opened this issue Sep 22, 2021 · 9 comments
Assignees
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed

Comments

@joeloff
Copy link
Member

joeloff commented Sep 22, 2021

Description: Some customers have strict CI policies around Device Guard. Even though WiX binaries are signed with the .NET Foundation authenticode certificates, the root certificate may not be in the allow list. Some customers do not want to add custom exclusions or install additional certificates on their machines.

To mitigate this, we've dual signed the WiX binaries with the Microsoft 3rd Party App SHA2 authenticode certificate in addition to the .NET Foundation SHA2

Impact: Installers that rely on built-in custom actions from WiX as well as some binaries that ship in the standalone bundles.

Risk: Low

Release: 6.0 RC2

Notes: This has been on tactics' radar for the last two weeks and already agreed to do this for RC2 so we have time to react to any issues before GA.

We have both a nupkg and .zip available. See dotnet/installer#12078 for an example. Note that the package ID have changed. The version tracks both the internal build and the WiX release so we can better manage rebuilds of the package or taking new releases from WiX.

@dougbu
Copy link
Contributor

dougbu commented Sep 22, 2021

@joeloff could you clarify where (which branches) and when (deadline) this issue should be addressed❔

Separately, I think this is more than an infrastructure change because the new WiX contains both additional signing of installers we ship to customers and @ericstj's ARM64 updates. If we need to do this in servicing, I lean toward ask-mode. Thoughts @dotnet/aspnet-build❔

@wtgodbe
Copy link
Member

wtgodbe commented Sep 22, 2021

I'm fine with doing it through ask-mode - like @joeloff mentioned, this is on tactics' radar so they shouldn't have an issue with it

@joeloff
Copy link
Member Author

joeloff commented Sep 22, 2021

No, it doesn't have Eric's changes in WiX yet. This is only a rebuild of WiX 3.14.0-dotnet that we've been using with additional authenticode certs. There will be a new WiX 3.14.x build and at that time, we'll take that and produce an updated version of Microsoft.Signed.Wix.

For now this is only for RC2. I'd hope to have the packages last week, but we had some CELA concerns to address, but I've been updating tactics twice a week for 2 weeks now, so they're expecting this.

Eventually we'll do 3.1 and 5.0

@dougbu
Copy link
Contributor

dougbu commented Sep 22, 2021

For now this is only for RC2.

So, this is really really urgent for realz. Right❔

@joeloff
Copy link
Member Author

joeloff commented Sep 22, 2021

For now this is only for RC2.

So, this is really really urgent for realz. Right❔

For realz. This is blocking some customers from installing .NET I can share more details offline

@dougbu dougbu self-assigned this Sep 22, 2021
@dougbu
Copy link
Contributor

dougbu commented Sep 22, 2021

Taking…

@dougbu
Copy link
Contributor

dougbu commented Sep 22, 2021

Created #36865. Please see my questions there.

That PR will automatically merge forward into 'release/6.0'. But, should I do the same thing in 'main'❔

@joeloff
Copy link
Member Author

joeloff commented Sep 23, 2021

I think once we've have a coherent build to evaluate fully and RC2 is out we can move on main.

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 23, 2021
@dougbu
Copy link
Contributor

dougbu commented Sep 23, 2021

a96feda though I forgot to fix the link to this issue in the commit description ☹️

@dougbu dougbu closed this as completed Sep 23, 2021
@dougbu dougbu added the Done This issue has been fixed label Sep 23, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Done This issue has been fixed
Projects
None yet
Development

No branches or pull requests

4 participants