Skip to content

Fix Caching_SendFileWithFullContentLength_Cached() #32853

@dougbu

Description

@dougbu

Error Message

Assert.Equal() Failure
↓ (pos 0)
Expected: 1
Actual:   2
↑ (pos 0)

Stacktrace

at Microsoft.AspNetCore.Server.HttpSys.FunctionalTests.ResponseCachingTests.Caching_SendFileWithFullContentLength_Cached() in /_/src/Servers/HttpSys/test/FunctionalTests/ResponseCachingTests.cs:line 401
--- End of stack trace from previous location ---

Build

https://dev.azure.com/dnceng/public/_build/results?buildId=1141411

Notes

Note the changes in #32508 (the PR validated in that build) are incredibly unlikely to cause unreliability in that test. At least anecdotally (per @Tratcher), the test is not reliable. That makes sense when other tests are contending for HTTP connections or otherwise slowing down when the test gets back to issuing its second GetFileAsync(...) call. May need more than a bump to the max-age=10 in the Cache-Control header.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionstest-failure

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions