IHtmlLocalizer<SharedResource> won't work with VS 2019 16.4 Preview 5

[vsfeedback]

This issue has been moved from a ticket on Developer Community.

---

[regression] [worked-in:16.4 Preview 2 to 16.4 Preview 5]
Using ASP .Net Core 3.0.

When using IHtmlLocalizer<SharedResource> in view (with AddLocalization(o => o.ResourcesPath = "Resources") in startup.cs) shared localization not work.
If I set AddLocalization(), shared localization work fine but not view localizations that using IViewLocalizer...

Structure :

Project
|-->Resources
|.....| -->Views
|.....| .....| -->Home
|.....| .....| .....| -->Index.fr-fr.resx
|.....| .....| .....| -->Index.en-us.resx
|.....| .....| -->Account
|.....| .....| .....| -->Index.fr-fr.resx
|.....| .....| .....| -->Index.en-us.resx
[...]
|.....| -->SaredResource.cs
|.....| -->SaredResource.fr-fr.resx
|.....| -->SaredResource.en-us.resx

Same code work fine with stable version of VS 2019 (16.3).

---

Original Comments

Visual Studio Feedback System on 11/20/2019, 01:45 AM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

---

Original Solutions

(no solutions)

[mkArtakMSFT]

@ryanbrandenburg can you please look into this? Thanks!

[Safirion]

Hi,

I don't understand the tag "5.0.0-preview1". Can't wait that much.

It must be fixed in next release of VS, I don't think it's related to ASP Net core since I use .Net Core 3.0 in both VS 2019 16.3 and VS 2019 16.4 Preview 5 ? It's the same csproj and it work fine with current release of VS, the bug appeared in the last preview of VS...

Does the compiler change between version of visual studio ? 🤔

[ryanbrandenburg]

@Safirion Please ensure you're reviewed this documentation. If you've reviewed that and still have trouble, is it a typo in your structure diagram or the code when it says SaredResource, but then your HtmlLocalizer is looking for ?

If neither of those solve your problem please include a GitHub repo which demonstrates the problem.

[Safirion]

@ryanbrandenburg Effectively it's a typo. File is correctly named in my project.
Not a documentation problem since it works fine until last VS Preview update.

I will try to make a demo project tonight.

[Safirion]

Fail too with VS 2019 16.4 Preview 6.

Project demo:
WebApplication1.zip

Page code:

@using System.Globalization
@{
    ViewData["Title"] = "Demo localization";
}

<div>Current culture : @(CultureInfo.CurrentUICulture.ToString())</div>
<div>Shared localizer : "@SL["HelloWorld"]"</div>
<div>View localizer : "@Localizer["PageLocalization"]" </div> 

(SL and Localizer variables are declared in _ViewImport.cshtml)

Results

[Safirion]

Any hope that it would be fix before the release of .Net Core 3.1 next week ?

[ryanbrandenburg]

I think perhaps there is a disconnect between what you're running locally and what you've included in that ZIP. The Startup.cs of your ZIP never called UseRequestLocalization in the Configure method, so I don't believe it ever would have Localized at all or even set your CurrentCulture. You need to do something like the following at the top of your Configure method:

var supportedCultures = new string[]{ "en-US", "fr-FR" };
app.UseRequestLocalization(options =>
    options
        .AddSupportedCultures(supportedCultures) 
        .AddSupportedUICultures(supportedCultures)
        .SetDefaultCulture("fr-FR")
        .RequestCultureProviders.Insert(0, new CustomRequestCultureProvider(context =>
        {
            return Task.FromResult(new ProviderCultureResult("fr-FR"));
        }))
);

Also, I don't believe it's the cause of your problems but I highly recommend you remove all the ItemGroup's except the one with the PackageReferences. The Web Sdk will take care of giving everything the appropriate Compile/Embed/etc status, and it should be unnecessary to modify things further in all but the strangest of cases.

Make those changes then if you're still seeing the behavior produce a new repro (preferably as a GitHub project for easy reference) using the exact code that it reproduced under.

[Safirion]

@ryanbrandenburg Thank's for reply.

I've patch the project with your suggestions and create a depo here : https://github.com/Safirion/LocalizationBugDemo

Bug is still present in last VS preview.

[ryanbrandenburg]

I was able to replicate this. It seems that when built with VS SharedResource.fr-FR.resx gets saved as WebApplication.SharedResource.fr-FR instead of WebApplication.Resources.SharedResource.fr-FR. The extra-strange thing is that Index.fr-FR.resx gets saved under the correct resource name regardless. It all seems related to the fact that SharedResource.cs is in the Resources folder. If you move that file out of the Resources folder (taking care to maintain a namespace which still reflects that structure) things work.

That appears to be a bug in VS, possibly related to the way they fold resx files with the same name under the cs file. I'm not sure how is best to report this to them, @mkArtakMSFT will probably know.