Localization not working after changing rootnamespace

[chrsas]

I have found issue #2645, but with my Asp.Net Core sample, it still does not work https://github.com/chrsas/LocalizationTest.

[mkArtakMSFT]

Thanks for contacting us, @chrsas.
We're currently busy with wrapping up our upcoming release and we will try to investigate this in the next milestone. In the meantime, StackOverflow may be a good place to start from, in case you'll get faster help there. Appreciate your understanding.

[hishamco]

This can be fixed used RootNamespaceAttribute. Have a look to the docs https://docs.microsoft.com/en-gb/aspnet/core/fundamentals/troubleshoot-aspnet-core-localization?view=aspnetcore-2.2#root-namespace-issues

[hishamco]

@mkArtakMSFT this has been answer and there's no respond from the author

[chrsas]

@hishamco You can see the file in my repo, RootNamespaceAttribute has been used, But it doesn't work.
https://github.com/chrsas/LocalizationTest/blob/master/LocalizationTest/AssemblyInfo.cs

[hishamco]

Let me check your sample, and get back to you ..

[hishamco]

After checking your sample, the first issue I notice which is unrelated is the order of localization middleware was wrong, please check this docs https://docs.microsoft.com/en-us/aspnet/core/fundamentals/troubleshoot-aspnet-core-localization?view=aspnetcore-2.2

The second thing which I can't confirm yet because I'm not unable to run the ASPNET.Core Extensions source, is that may be there's a bug in the basename. I made your app running well, but I need to check few tests cases before I confirm and send a PR for it

[chrsas]

@hishamco Thanks for your reply, waiting for your good news.

[hishamco]

@chrsas If I'm not wrong there's a bug which may not obvious, I will prepare a PR for it.

Now to make your application works fine, I need to add NewResourceManagerStringLocalizerFactory as a workaround, here is the code:

public void ConfigureServices(IServiceCollection services)
{
    services.AddSingleton<IStringLocalizerFactory, NewResourceManagerStringLocalizerFactory>();
    services.AddLocalization();
    services.AddMvc().SetCompatibilityVersion(CompatibilityVersion.Version_2_2);
}

public class NewResourceManagerStringLocalizerFactory : ResourceManagerStringLocalizerFactory
{
    public NewResourceManagerStringLocalizerFactory(IOptions<LocalizationOptions> localizationOptions, ILoggerFactory loggerFactory) : base(localizationOptions, loggerFactory)
    {

    }

    protected override string GetResourcePrefix(TypeInfo typeInfo, string baseNamespace, string resourcesRelativePath)
    {
        if (typeInfo == null)
        {
            throw new ArgumentNullException(nameof(typeInfo));
        }

        if (string.IsNullOrEmpty(baseNamespace))
        {
            throw new ArgumentNullException(nameof(baseNamespace));
        }

        if (string.IsNullOrEmpty(resourcesRelativePath))
        {
            return typeInfo.FullName;
        }
        else
        {
            return baseNamespace + "." + resourcesRelativePath + TrimPrefix(typeInfo.FullName, baseNamespace + ".");
        }
    }
    private static string TrimPrefix(string name, string prefix)
    {
        if (name.StartsWith(prefix, StringComparison.Ordinal))
        {
            return name.Substring(prefix.Length);
        }

        return name;
    }
}

@ryanbrandenburg correct me if I'm wrong