-
Notifications
You must be signed in to change notification settings - Fork 717
Default Choice inputs to first option when no placeholder is set and custom choice is disabled #11918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Default Choice inputs to first option when no placeholder is set and custom choice is disabled #11918
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 181 additions & 0 deletions
181
tests/Aspire.Dashboard.Components.Tests/Model/InputViewModelTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Aspire.Dashboard.Model.Interaction; | ||
| using Aspire.DashboardService.Proto.V1; | ||
| using Xunit; | ||
|
|
||
| namespace Aspire.Dashboard.Components.Tests.Model; | ||
|
|
||
| public class InputViewModelTests | ||
| { | ||
| [Fact] | ||
| public void InputViewModel_ChoiceWithoutPlaceholder_DefaultsToFirstOption() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice, | ||
| }; | ||
| input.Options.Add("red", "Red"); | ||
| input.Options.Add("blue", "Blue"); | ||
| input.Options.Add("green", "Green"); | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert | ||
| Assert.Equal("red", viewModel.Value); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void InputViewModel_ChoiceWithPlaceholder_DoesNotDefaultToFirstOption() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice, | ||
| Placeholder = "Select a color" | ||
| }; | ||
| input.Options.Add("red", "Red"); | ||
| input.Options.Add("blue", "Blue"); | ||
| input.Options.Add("green", "Green"); | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert - proto strings default to empty string, not null | ||
| Assert.True(string.IsNullOrEmpty(viewModel.Value)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void InputViewModel_ChoiceWithExistingValue_KeepsExistingValue() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice, | ||
| Value = "blue" | ||
| }; | ||
| input.Options.Add("red", "Red"); | ||
| input.Options.Add("blue", "Blue"); | ||
| input.Options.Add("green", "Green"); | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert | ||
| Assert.Equal("blue", viewModel.Value); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void InputViewModel_ChoiceWithEmptyOptions_DoesNotSetValue() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice | ||
| }; | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert - proto strings default to empty string, not null | ||
| Assert.True(string.IsNullOrEmpty(viewModel.Value)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void InputViewModel_NonChoiceInput_DoesNotSetValue() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Enter Text", | ||
| InputType = InputType.Text | ||
| }; | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert - proto strings default to empty string, not null | ||
| Assert.True(string.IsNullOrEmpty(viewModel.Value)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void SetInput_ChoiceWithoutPlaceholder_DefaultsToFirstOption() | ||
| { | ||
| // Arrange | ||
| var initialInput = new InteractionInput | ||
| { | ||
| Label = "Enter Text", | ||
| InputType = InputType.Text | ||
| }; | ||
| var viewModel = new InputViewModel(initialInput); | ||
|
|
||
| var choiceInput = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice | ||
| }; | ||
| choiceInput.Options.Add("red", "Red"); | ||
| choiceInput.Options.Add("blue", "Blue"); | ||
|
|
||
| // Act | ||
| viewModel.SetInput(choiceInput); | ||
|
|
||
| // Assert | ||
| Assert.Equal("red", viewModel.Value); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void SetInput_ChoiceWithPlaceholder_DoesNotDefaultToFirstOption() | ||
| { | ||
| // Arrange | ||
| var initialInput = new InteractionInput | ||
| { | ||
| Label = "Enter Text", | ||
| InputType = InputType.Text | ||
| }; | ||
| var viewModel = new InputViewModel(initialInput); | ||
|
|
||
| var choiceInput = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice, | ||
| Placeholder = "Select a color" | ||
| }; | ||
| choiceInput.Options.Add("red", "Red"); | ||
| choiceInput.Options.Add("blue", "Blue"); | ||
|
|
||
| // Act | ||
| viewModel.SetInput(choiceInput); | ||
|
|
||
| // Assert - proto strings default to empty string, not null | ||
| Assert.True(string.IsNullOrEmpty(viewModel.Value)); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void InputViewModel_ChoiceWithAllowCustomChoice_DoesNotDefaultToFirstOption() | ||
| { | ||
| // Arrange | ||
| var input = new InteractionInput | ||
| { | ||
| Label = "Choose Color", | ||
| InputType = InputType.Choice, | ||
| AllowCustomChoice = true | ||
| }; | ||
| input.Options.Add("red", "Red"); | ||
| input.Options.Add("blue", "Blue"); | ||
| input.Options.Add("green", "Green"); | ||
|
|
||
| // Act | ||
| var viewModel = new InputViewModel(input); | ||
|
|
||
| // Assert - When AllowCustomChoice is true, value should not default | ||
| Assert.True(string.IsNullOrEmpty(viewModel.Value)); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.