Revamp activity reporter to support multiple steps and tasks in parallel #11780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11780Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11780" |
github-actions
bot
added
the
needs-area-label
captainsafia
added
area-deployment
and removed
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR revamps the publishing activity reporter to support multiple steps and tasks running in parallel, removing the previous limitation where interactions were blocked when steps were in progress. The changes enable a more flexible deployment pipeline UI that can handle concurrent operations.
Key changes:
- Removed blocking behavior for user interactions during step execution
- Replaced the progress-based UI with a log-style output renderer that supports parallel operations
- Simplified the activity processing logic by removing complex progress context management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/Aspire.Hosting.Tests/Publishing/PublishingActivityReporterTests.cs |
Updated test to verify interactions are now allowed during step execution instead of being blocked |
src/Aspire.Hosting/Publishing/PublishingActivityReporter.cs |
Removed the blocking logic that prevented interactions when steps were in progress |
src/Aspire.Cli/Commands/PublishCommandBase.cs |
Completely rewrote the UI rendering system from progress bars to a log-style output with spinner and color-coded messages |
|
video? |
|
|
Needs work. @maddymontaquila please try |
captainsafia
force-pushed
the
safia/publish-activity-ux
branch
2 times, most recently
from
02b4bbb to
5d7d57a
Compare
captainsafia
force-pushed
the
safia/publish-activity-ux
branch
from
48a37ce to
ef8576f
Compare
davidfowl
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11524 and contributes towards #11750.
We want to make it easier to model steps and tasks in a deployment pipeline. One of the concrete limitatiosn is the way we map PublishingSteps/PublishingTasks to UI elements. This adjusts the CLI UI so that we can do parallel steps and create new steps while others are in progress.