[tests] Ensure emulator is killed #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "funny thing" happened in [PR Build dotnet#958][0]: `adb` failed: Target ReleaseAndroidTarget: Task "Adb" ... Tool /Users/builder/android-toolchain/sdk/platform-tools/adb execution started with arguments: -s emulator-5570 logcat -d ... Task "Adb" execution -- FAILED I have no idea why `adb` is failing, but *because* it failed, the emulator was never shutdown and killed. Add `ContinueOnError="True"` to most of the tasks within the `ReleaseAndroidTarget` target to ensure that the emulator is shutdown and killed. [0]: https://jenkins.mono-project.com/job/xamarin-android-pr-builder/958/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "funny thing" happened in PR Build #958:
adbfailed:I have no idea why
adbis failing, but because it failed, theemulator was never shutdown and killed.
Add
ContinueOnError="True"to most of the tasks within theReleaseAndroidTargettarget to ensure that the emulator is shutdownand killed.