Skip to content

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 17, 2021

Context: #5726

We have someone willing to contribute fixes for
Xamarin.Android.Tools.Aidl.dll (yay!). However, we no longer have
any expertise with AIDL available on the team, and there are no unit
tests for this area. This makes us very reluctant to make changes
which could potentially break the currently working aspects of AIDL.

Add a new tests/Xamarin.Android.Tools.Aidl-Tests unit test project
and seed it with a few examples from our repo and a few large examples
from other OSS repos.

Note: this does not mean that the behavior tested by these tests is
necessarily correct. It simply reflects what the code does today,
in order that we can see any changes made by future PR's.

~~ Note ~~

The format for test data files is delimited by 4 pound signs as:

<input>

####

<output>

Test results can be generated by:

  • Placing the input in a test file
  • Enabling the GENERATE_OUTPUT define at the top of
    AidlCompilerTestBase.cs
  • Running the test
  • The test file in bin/TestData will now contain the test output
    which can be copied back to the original test data file.

@jpobst jpobst force-pushed the aidl-tests branch 3 times, most recently from a140397 to 8231a7d Compare March 19, 2021 15:24
@jonpryor jonpryor merged commit 81d37a1 into main Mar 25, 2021
@jonpryor jonpryor deleted the aidl-tests branch March 25, 2021 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants