[build] Write a download message for missing dependencies #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Argh! |
Contributor
Author
|
build |
Commit 2063ab7 tried to improve error messages when required dependencies are missing. Unfortunately, there was one case not considered: when `$(AutoProvision)` is False, and a dependency to install needs to be downloaded. For example, take [PR 445][0], which requires an updated mono. If the system mono is unsuported, the required mono hasn't already been downloaded, and `$(AutoProvision)` is False, then the following "helpful" error message is provided: error : Could not find required program 'mono'. Please run: installer -pkg "$HOME/android-archives/MonoFramework-MDK-4.8.0.489.macos10.xamarin.universal.pkg" -target / If `MonoFramework-MDK-4.8.0.489.macos10.xamarin.universal.pkg` hasn't already been downloaded, then the suggested command will fail. This is not helpful. :-) Thus, when `$(AutoProvision)` is False and URLs need to be downloaded, then provide a message stating that: Please download `https://.../MonoFramework-MDK-4.8.0.489.macos10.xamarin.universal.pkg` into `$HOME/android-archives/MonoFramework-MDK-4.8.0.489.macos10.xamarin.universal.pkg`. [0]: dotnet#445
jonpryor
force-pushed
the
jonp-download-message
branch
from
20156c0 to
0445e37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 2063ab7 tried to improve error messages when required
dependencies are missing. Unfortunately, there was one case not
considered: when
$(AutoProvision)is False, and a dependency toinstall needs to be downloaded.
For example, take PR 445, which requires an updated mono.
If the system mono is unsuported, the required mono hasn't already
been downloaded, and
$(AutoProvision)is False, then the following"helpful" error message is provided:
If
MonoFramework-MDK-4.8.0.489.macos10.xamarin.universal.pkghasn'talready been downloaded, then the suggested command will fail.
This is not helpful. :-)
Thus, when
$(AutoProvision)is False and URLs need to be downloaded,then provide a message stating that: