Skip to content

Conversation

jonpryor
Copy link
Contributor

@jonpryor jonpryor commented Jun 7, 2020

Context: #4567
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3729696&view=ms.vss-test-web.build-test-results-tab&runId=13228096&resultId=100066&paneView=attachments

<CreateMultiDexMainDexClassList/> fails under JDK11:

$ /Users/runner/Library/Android/jdk/bin/java \
	-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib \
	com.android.multidex.MainDexListBuilder …
-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib is not supported.  Use -classpath instead.
CREATEMULTIDEXMAINDEXCLASSLIST : error : Could not create the Java Virtual Machine.
CREATEMULTIDEXMAINDEXCLASSLIST : error : A fatal exception has occurred. Program will exit.
The command exited with code 1.

Under JDK11, java no longer supports -Djava.ext.dirs.

Update <CreateMultiDexMainDexClassList/> so that it constructs a
java -classpath value and uses that.

Context: dotnet#4567
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3729696&view=ms.vss-test-web.build-test-results-tab&runId=13228096&resultId=100066&paneView=attachments

`<CreateMultiDexMainDexClassList/>` fails under JDK11:

	$ /Users/runner/Library/Android/jdk/bin/java \
		-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib \
		com.android.multidex.MainDexListBuilder …
	-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib is not supported.  Use -classpath instead.
	CREATEMULTIDEXMAINDEXCLASSLIST : error : Could not create the Java Virtual Machine.
	CREATEMULTIDEXMAINDEXCLASSLIST : error : A fatal exception has occurred. Program will exit.
	The command exited with code 1.

Under JDK11, `java` no longer supports `-Djava.ext.dirs`.

Update `<CreateMultiDexMainDexClassList/>` so that it constructs a
`java -classpath` value and uses that.
@jonpryor jonpryor merged commit 895b7bc into dotnet:master Jun 7, 2020
jonpryor added a commit that referenced this pull request Jun 8, 2020
…11 (#4782)

Context: #4567
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3729696&view=ms.vss-test-web.build-test-results-tab&runId=13228096&resultId=100066&paneView=attachments

`<CreateMultiDexMainDexClassList/>` fails under JDK11:

	$ /Users/runner/Library/Android/jdk/bin/java \
		-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib \
		com.android.multidex.MainDexListBuilder …
	-Djava.ext.dirs=/Users/runner/Library/Android/sdk/build-tools/29.0.2/lib is not supported.  Use -classpath instead.
	CREATEMULTIDEXMAINDEXCLASSLIST : error : Could not create the Java Virtual Machine.
	CREATEMULTIDEXMAINDEXCLASSLIST : error : A fatal exception has occurred. Program will exit.
	The command exited with code 1.

Under JDK11, `java` no longer supports `-Djava.ext.dirs`.

Update `<CreateMultiDexMainDexClassList/>` so that it constructs a
`java -classpath` value and uses that.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants