[tests] Run adb logcat -d if any .apk tests fail
#477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in commit 3b893cd, [PR 445][0] was showing up as a successful build, while none of the .apk tests ran. Commit 3b893cd "improves" matters by ensuring that we flag this as an error, instead of blithely ignoring it. Unfortunately, knowing that there's an error doesn't help in diagnosing what the error *is*. In the case of segmentation faults, the `INSTRUMENTATION_RESULT` messages will *not* be helpful. What *would* be helpful is `adb logcat` output, which we don't capture. Let's fix that: if an error occurs -- e.g. `RunInstrumentationTests.FailedToRun` is a non-empty string, which is collected in the `@(_FailedComponent)` item group -- then we should run `adb logcat -d` before terminating the emulator. This will cause the build and test log output to contain `adb logcat` output, which may provide *some* additional context regarding .apk failures. [0]: dotnet#445
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in commit 3b893cd, PR 445 was showing up as a
successful build, while none of the .apk tests ran.
Commit 3b893cd "improves" matters by ensuring that we flag this as an
error, instead of blithely ignoring it.
Unfortunately, knowing that there's an error doesn't help in
diagnosing what the error is. In the case of segmentation faults,
the
INSTRUMENTATION_RESULTmessages will not be helpful.What would be helpful is
adb logcatoutput, which we don'tcapture.
Let's fix that: if an error occurs -- e.g.
RunInstrumentationTests.FailedToRunis a non-empty string, which iscollected in the
@(_FailedComponent)item group -- then we shouldrun
adb logcat -dbefore terminating the emulator. This will causethe build and test log output to contain
adb logcatoutput, whichmay provide some additional context regarding .apk failures.