[Xamarin.Android.Build.Tasks] detect OS changes. #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user shares a project between Mac and Windows they will probably get some errors. This is mainly because the various cache's that are in place will contain invalid paths. This commit adds the $(OS) to the build.props file which will allow us to detect if the OS changed.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 9, 2017
While reviewing [PR 445][0] I noticed that it said that *41* tests had
been run, and 0 failed. Compare to e.g. [PR 474][1], which has *164*
passing tests.
Something isn't right here.
Further investigation showed that for PR 445, execution on the
emulator had crashed ("Segmentation fault"). The error was ignored.
Ignoring errors was in fact By Design™; see commit 6358a64.
So what we need is for the `RunUnitTestApks` target to *not* report
errors, while still reporting errors.
Solve this conundrum by updating the `<RunInstrumentationTests/>` task
so that when the `nunit2-results-path` value can't be found, it
reports a *successful* run, and sets the
`RunInstrumentationTests.FailedToRun` property to the name of the
component that failed. This allows the `ReleaseAndroidTarget` target
to check for any failures, and report an `<Error/>` after shutting
down the emulator instance.
This should allow the build to "fail" when `nunit2-results-path` can't
be found -- a sign that the `.apk` unit tests didn't finish executing
-- while also allowing the emulator to be shut down.
Aside: `xbuild` doesn't support `ContinueOnError="ErrorAndContinue"`,
nor does it set `<Output/>` properties whenever a task fails.
Consequently, the `<RunInstrumentationTests/>` task *must* return true
when `nunit2-results-path` isn't found, because there's no other way
to convince `xbuild` to collect the `<Output/>` values.
[0]: dotnet#445
[1]: dotnet#474
dellis1972
pushed a commit
that referenced
this pull request
Mar 9, 2017
While reviewing [PR 445][0] I noticed that it said that *41* tests had
been run, and 0 failed. Compare to e.g. [PR 474][1], which has *164*
passing tests.
Something isn't right here.
Further investigation showed that for PR 445, execution on the
emulator had crashed ("Segmentation fault"). The error was ignored.
Ignoring errors was in fact By Design™; see commit 6358a64.
So what we need is for the `RunUnitTestApks` target to *not* report
errors, while still reporting errors.
Solve this conundrum by updating the `<RunInstrumentationTests/>` task
so that when the `nunit2-results-path` value can't be found, it
reports a *successful* run, and sets the
`RunInstrumentationTests.FailedToRun` property to the name of the
component that failed. This allows the `ReleaseAndroidTarget` target
to check for any failures, and report an `<Error/>` after shutting
down the emulator instance.
This should allow the build to "fail" when `nunit2-results-path` can't
be found -- a sign that the `.apk` unit tests didn't finish executing
-- while also allowing the emulator to be shut down.
Aside: `xbuild` doesn't support `ContinueOnError="ErrorAndContinue"`,
nor does it set `<Output/>` properties whenever a task fails.
Consequently, the `<RunInstrumentationTests/>` task *must* return true
when `nunit2-results-path` isn't found, because there's no other way
to convince `xbuild` to collect the `<Output/>` values.
[0]: #445
[1]: #474
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user shares a project between Mac and Windows they
will probably get some errors. This is mainly because
the various cache's that are in place will contain
invalid paths.
This commit adds the $(OS) to the build.props file which
will allow us to detect if the OS changed.