[msbuild] Applications crashing with System.DllNotFoundException: sqlite3 for projects that reference sqlite but don't use fastdev (#415)
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lite3` for projects that reference sqlite but don't use fastdev (dotnet#415) Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=40804 There was an issue with the way the dll.config files were extracted from the apk. They were including additional data at the end of the xml because the files were not null terminated. This patch fixes the null termination for user included config files and those included in the debug runtime. It also adds method to extract the config file from the apk (this was apparently missing too).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=40804
There was an issue with the way the dll.config files were
extracted from the apk. They were including additional data
at the end of the xml because the files were not null
terminated.
This patch fixes the null termination for user included
config files and those included in the debug runtime.
It also adds method to extract the config file from the apk
(this was apparently missing too).