[Xamarin.Android.Build.Tasks] Add @(AndroidAarLibrary) #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `@(AndroidAarLibrary)` to `@(AvailableItemName)` *should* have been done as part of commit 6a8ea2b, but was overlooked. We want `@(AvailableItemName)` to be up-to-date so that you can have conditional MSBuild behavior based on whether a particular item is supported. In particular, @Redth wants to ensure that the `@(AndroidAarLibrary)` build action is available as part of his Components work, and ensuring that `@(AvailableItemName)` contains `@(AndroidAarLibrary)` is the most straightforward way to do so. Additionally, sort and re-indent the `@(AvailableItemName)` entries.
jonpryor
force-pushed
the
jonp-add-AvailableItemName-AndroidAarLibrary
branch
from
18f14d4 to
b5dc3cc
Compare
dellis1972
approved these changes
Mar 7, 2018
jonpryor
added a commit
that referenced
this pull request
Mar 9, 2018
Adding `@(AndroidAarLibrary)` to `@(AvailableItemName)` *should* have been done as part of commit 6a8ea2b, but was overlooked. We want `@(AvailableItemName)` to be up-to-date so that you can have conditional MSBuild behavior based on whether a particular item is supported. In particular, @Redth wants to ensure that the `@(AndroidAarLibrary)` build action is available as part of his Components work, and ensuring that `@(AvailableItemName)` contains `@(AndroidAarLibrary)` is the most straightforward way to do so. Additionally, sort and re-indent the `@(AvailableItemName)` entries.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
@(AndroidAarLibrary)to@(AvailableItemName)should havebeen done as part of commit 6a8ea2b, but was overlooked.
We want
@(AvailableItemName)to be up-to-date so that you can haveconditional MSBuild behavior based on whether a particular item is
supported.
In particular, @Redth wants to ensure that the
@(AndroidAarLibrary)build action is available as part of his Components work, and ensuring
that
@(AvailableItemName)contains@(AndroidAarLibrary)is themost straightforward way to do so.
Additionally, sort and re-indent the
@(AvailableItemName)entries.