[Xamarin.Android.Build.Tasks] Add Properties for the Debug Key #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
reviewed
Mar 6, 2018
| <AndroidSdkToolsVersion Condition="'$(AndroidSdkToolsVersion)' == ''">26.1.1</AndroidSdkToolsVersion> | ||
| <AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">16.1</AndroidNdkVersion> | ||
|
|
||
| <AndroidDebugKeyAlgorithm>RSA</AndroidDebugKeyAlgorithm> |
Contributor
There was a problem hiding this comment.
This should be conditional, not hardcoded.
jonpryor
reviewed
Mar 7, 2018
| <AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">16.1</AndroidNdkVersion> | ||
|
|
||
| <AndroidDebugKeyAlgorithm Condition=" '$(AndroidDebugKeyAlgorithm)' == '' ">RSA</AndroidDebugKeyAlgorithm> | ||
| <AndroidDebugKeyValidity Condition=" $(AndroidDebugKeyValidity)'' == '' ">10950</AndroidDebugKeyValidity> |
Contributor
There was a problem hiding this comment.
This is improperly quoted, and results in a build error:
Unable to parse condition " $(AndroidDebugKeyValidity)'' == '' " : Unexpected token found, "" at character position 28, in condition " $(AndroidDebugKeyValidity)'' == '' "
dellis1972
force-pushed
the
debugkeyprops
branch
from
3192a3d to
3b6553f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #1361
This change will allow developers to override our defaults and pick stronger values if required.