Don't require quotes around release values
#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| string key = line.Substring (0, delim); | ||
| string value = line.Substring (delim + PropertyDelim.Length, line.Length - delim - PropertyDelim.Length - 1); | ||
| string value = line.Substring (delim + PropertyDelim.Length); |
Member
There was a problem hiding this comment.
Should consider any other weirdness that could happen when parsing this text?
Maybe a call to Trim () for the original key and value? Such as:
KEY_A = 1234
KEY_B = "Some text here"
Fixes: dotnet#39 The `release` file contained within the [Microsoft OpenJDK Distribution Preview][0] contains an entry which broke the `release` parser within `JdkInfo`, an entry which doesn't contain double quotes around the value: BUILD_NUMBER=9 This causes an exception to be thrown when `JdkInfo` attempts to parse the `release` file: System.ArgumentOutOfRangeException : Length cannot be less than zero. Parameter name: length at System.String.Substring (System.Int32 startIndex, System.Int32 length) [0x0004a] in <7e59c4ad7b424f9eab0db1b78ec1804f>:0 at Xamarin.Android.Tools.JdkInfo.GetReleaseProperties () [0x0006b] in <3975ab851981476abded14492926b261>:0 at Xamarin.Android.Tools.JdkInfo..ctor (System.String homePath) [0x00159] in <3975ab851981476abded14492926b261>:0 Update `JdkInfo.GetReleaseProperties()` so that the double-quotes around values are *optional* and not required, so that this `release` file may be processed without throwing an exception. [0]: https://dl.xamarin.com/OpenJDK/mac/microsoft-dist-openjdk-1.8.0.9.zip
jonpryor
force-pushed
the
jonp-release-parsing
branch
from
ee90ba2 to
e13a92a
Compare
jonathanpeppers
approved these changes
Aug 1, 2018
jonpryor
added a commit
that referenced
this pull request
Aug 2, 2018
Fixes: #39 The `release` file contained within the [Microsoft OpenJDK Distribution Preview][0] contains an entry which broke the `release` parser within `JdkInfo`, an entry which doesn't contain double quotes around the value: BUILD_NUMBER=9 This causes an exception to be thrown when `JdkInfo` attempts to parse the `release` file: System.ArgumentOutOfRangeException : Length cannot be less than zero. Parameter name: length at System.String.Substring (System.Int32 startIndex, System.Int32 length) [0x0004a] in <7e59c4ad7b424f9eab0db1b78ec1804f>:0 at Xamarin.Android.Tools.JdkInfo.GetReleaseProperties () [0x0006b] in <3975ab851981476abded14492926b261>:0 at Xamarin.Android.Tools.JdkInfo..ctor (System.String homePath) [0x00159] in <3975ab851981476abded14492926b261>:0 Update `JdkInfo.GetReleaseProperties()` so that the double-quotes around values are *optional* and not required, so that this `release` file may be processed without throwing an exception. [0]: https://dl.xamarin.com/OpenJDK/mac/microsoft-dist-openjdk-1.8.0.9.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39
The
releasefile contained within theMicrosoft OpenJDK Distribution Preview contains an entry which
broke the
releaseparser withinJdkInfo, an entry which doesn'tcontain double quotes around the value:
This causes an exception to be thrown when
JdkInfoattempts to parsethe
releasefile:Update
JdkInfo.GetReleaseProperties()so that the double-quotesaround values are optional and not required, so that this
releasefile may be processed without throwing an exception.