Add AndroidSdkInfo.DetectAndSetPreferredJavaSdkPathToLatest() #35
+83
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratsche
reviewed
Jul 27, 2018
|
|
||
| var latestJdk = JdkInfo.GetMacOSMicrosoftJdks (logger).FirstOrDefault (); | ||
| if (latestJdk == null) | ||
| throw new NotSupportedException ("No preferred Java SDK could be found."); |
Contributor
There was a problem hiding this comment.
JdkInfo.GetMacOSMicrosoftJdks() returns a list of all our Microsoft OpenJDK installs, not a list of preferred Java SDKs, right? This exception message might cause some confusion.
bratsche
approved these changes
Jul 27, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Add `AndroidSdkInfo.DetectAndSetPreferredJavaSdkPathToLatest()`.
jonpryor
force-pushed
the
jonp-DetectAndSetPreferredJavaSdkPathToLatest
branch
from
c99f168 to
91c2ddd
Compare
jonpryor
added a commit
that referenced
this pull request
Aug 2, 2018
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea Add `AndroidSdkInfo.DetectAndSetPreferredJavaSdkPathToLatest()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://paper.dropbox.com/doc/OpenJDK-and-You--AH1yWKdVXgno~uXYfmcUAZTwAg-NoECAe2XkBQeoxFfGL6ea
Add
AndroidSdkInfo.DetectAndSetPreferredJavaSdkPathToLatest().