Skip to content

Conversation

@moljac
Copy link
Contributor

@moljac moljac commented Oct 26, 2022

Does this change any of the generated binding API's?

Yes. (New packages and dependencies)

Describe your contribution

Bound material3 and dependencies:

  • androidx.compose.animation:animation - 1.2.1 -> 1.3.0
  • androidx.compose.animation:animation-core - 1.2.1 -> 1.3.0
  • androidx.compose.animation:animation-graphics - -> 1.3.0
  • androidx.compose.foundation:foundation - 1.2.1 -> 1.3.0
  • androidx.compose.foundation:foundation-layout - 1.2.1 -> 1.3.0
  • androidx.compose.material:material - 1.2.1 -> 1.3.0
  • androidx.compose.material:material-icons-core - 1.2.1 -> 1.3.0
  • androidx.compose.material:material-icons-extended - 1.2.1 -> 1.3.0
  • androidx.compose.material:material-ripple - 1.2.1 -> 1.3.0
  • androidx.compose.material3:material3 - -> 1.0.0
  • androidx.compose.material3:material3-windowsizeclass - -> 1.0.0
  • androidx.compose.runtime:runtime - 1.2.1 -> 1.3.0
  • androidx.compose.runtime:runtime-livedata - 1.2.1 -> 1.3.0
  • androidx.compose.runtime:runtime-rxjava2 - 1.2.1 -> 1.3.0
  • androidx.compose.runtime:runtime-rxjava3 - -> 1.3.0
  • androidx.compose.runtime:runtime-saveable - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-geometry - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-graphics - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-text - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-tooling - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-tooling-data - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-tooling-preview - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-unit - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-util - 1.2.1 -> 1.3.0
  • androidx.compose.ui:ui-viewbinding - 1.2.1 -> 1.3.0
  • com.google.android.material:compose-themeadapter-3 - -> 1.0.18

@moljac moljac linked an issue Oct 26, 2022 that may be closed by this pull request
@moljac moljac linked an issue Oct 26, 2022 that may be closed by this pull request
@moljac
Copy link
Contributor Author

moljac commented Oct 26, 2022

#637

@moljac moljac requested a review from jpobst October 26, 2022 09:56
Copy link
Contributor

@jpobst jpobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the other "compose" packages we used this to prevent managed bindings from being created:

<remove-node path="/api/package" />

Should we be doing that with these compose packages as well?

@moljac
Copy link
Contributor Author

moljac commented Oct 27, 2022

For all the other "compose" packages we used this to prevent managed bindings from being created:

<remove-node path="/api/package" />

Should we be doing that with these compose packages as well?

I am a little bit confused with interrogative form of the comment. Namely, I am aware that Compose cannot be used from managed code (for now, if ever), but I don't remember adding (and the reason for adding):

<remove-node path="/api/package" />

Checking git blame I see you added it for namespaces

https://github.com/xamarin/AndroidX/blame/4977973e4c935dfbcfe2e5f0b9e6853e59767342/source/androidx.compose.animation/animation-core/Transforms/Metadata.xml#L2

Use instead of metadata to rename namespaces

Use instead of metadata to rename nam

@jpobst
Copy link
Contributor

jpobst commented Oct 27, 2022

<remove-node path="/api/package" />

I think it was added in the PR where we added those packages:
#352

I simply moved them from Metadata.Namespaces.xml to Metadata.xml:
0aaa542#diff-9cb222843becbdac30f925bae0bd249c2db654bace8140128451a757b47ed24e

@moljac
Copy link
Contributor Author

moljac commented Oct 27, 2022

<remove-node path="/api/package" />

I think it was added in the PR where we added those packages: #352

Could be. I don't remember. I changed according to suggestions.

Copy link
Contributor

@jpobst jpobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a comment on the PR for why com.google.android.material:compose-theme-adapter-3 is marked as frozen so we have it documented somewhere.

@moljac moljac merged commit 1112577 into main Oct 27, 2022
@moljac moljac deleted the mu-20221025-material3 branch October 27, 2022 18:22
@MagicAndre1981
Copy link

@moljac @jpobst the packages from this PR miss the new description from #623

image

What went wrong here?

@jpobst
Copy link
Contributor

jpobst commented Nov 1, 2022

Looks like this additional place needs to be updated:
https://github.com/xamarin/AndroidX/blob/c2c90e96e2f2cf0eaac8b255ca962619f0ce2f76/source/AndroidXProject.cshtml#L233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bind androidx.compose.material3

4 participants