-
Notifications
You must be signed in to change notification settings - Fork 63
Manual updates 20221025 material3 #639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jpobst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all the other "compose" packages we used this to prevent managed bindings from being created:
<remove-node path="/api/package" />Should we be doing that with these compose packages as well?
I am a little bit confused with interrogative form of the comment. Namely, I am aware that Compose cannot be used from managed code (for now, if ever), but I don't remember adding (and the reason for adding): <remove-node path="/api/package" />Checking git blame I see you added it for namespaces Use instead of metadata to rename namespaces |
I think it was added in the PR where we added those packages: I simply moved them from |
Could be. I don't remember. I changed according to suggestions. |
jpobst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add a comment on the PR for why com.google.android.material:compose-theme-adapter-3 is marked as frozen so we have it documented somewhere.
|
Looks like this additional place needs to be updated: |

Does this change any of the generated binding API's?
Yes. (New packages and dependencies)
Describe your contribution
Bound
material3and dependencies:androidx.compose.animation:animation- 1.2.1 -> 1.3.0androidx.compose.animation:animation-core- 1.2.1 -> 1.3.0androidx.compose.animation:animation-graphics- -> 1.3.0androidx.compose.foundation:foundation- 1.2.1 -> 1.3.0androidx.compose.foundation:foundation-layout- 1.2.1 -> 1.3.0androidx.compose.material:material- 1.2.1 -> 1.3.0androidx.compose.material:material-icons-core- 1.2.1 -> 1.3.0androidx.compose.material:material-icons-extended- 1.2.1 -> 1.3.0androidx.compose.material:material-ripple- 1.2.1 -> 1.3.0androidx.compose.material3:material3- -> 1.0.0androidx.compose.material3:material3-windowsizeclass- -> 1.0.0androidx.compose.runtime:runtime- 1.2.1 -> 1.3.0androidx.compose.runtime:runtime-livedata- 1.2.1 -> 1.3.0androidx.compose.runtime:runtime-rxjava2- 1.2.1 -> 1.3.0androidx.compose.runtime:runtime-rxjava3- -> 1.3.0androidx.compose.runtime:runtime-saveable- 1.2.1 -> 1.3.0androidx.compose.ui:ui- 1.2.1 -> 1.3.0androidx.compose.ui:ui-geometry- 1.2.1 -> 1.3.0androidx.compose.ui:ui-graphics- 1.2.1 -> 1.3.0androidx.compose.ui:ui-text- 1.2.1 -> 1.3.0androidx.compose.ui:ui-tooling- 1.2.1 -> 1.3.0androidx.compose.ui:ui-tooling-data- 1.2.1 -> 1.3.0androidx.compose.ui:ui-tooling-preview- 1.2.1 -> 1.3.0androidx.compose.ui:ui-unit- 1.2.1 -> 1.3.0androidx.compose.ui:ui-util- 1.2.1 -> 1.3.0androidx.compose.ui:ui-viewbinding- 1.2.1 -> 1.3.0com.google.android.material:compose-themeadapter-3- -> 1.0.18