Cleanup | Convert SniLoadHandle to static class #3768
Merged
+40
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces a ThreadLocal<T> value (which we would need to dispose of) with a simpler [ThreadStatic] variable.
mdaigle
approved these changes
Nov 14, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
@edwardneal This will need a rebase/merge from main to pickup the new PR pipeline configs. |
paulmedynski
approved these changes
Nov 17, 2025
Contributor
Author
|
Thanks @paulmedynski I've just merged main. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3768 +/- ##
==========================================
- Coverage 76.59% 69.95% -6.65%
==========================================
Files 274 268 -6
Lines 43395 43075 -320
==========================================
- Hits 33240 30134 -3106
- Misses 10155 12941 +2786
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor correctness issue and might also contribute to #1687 - this field was one of several lingering on the heap when trying to unload a collectible AssemblyLoadContext.
The managed SNI's
SniLoadHandlecurrently has a per-threadLastErrorproperty which references aThreadLocal<SniError>. ThreadLocal is disposable, but we have no clear opportunity to dispose of it when the AssemblyLoadContext is unloaded.The entire class is a singleton which only exposes a single meaningful property,
LastError. I've converted SniLoadHandle into a static class, then replaced theThreadLocalwith a simpler[ThreadStatic]variable.Issues
Related to #1687. It doesn't fix the issue, but it's one of the two fixes which are easiest to pick out from a broader set of changes.
Testing
Automated tests continue to pass.