Abstractions Package - Pipeline Changes #3628

paulmedynski · 2025-09-23T12:53:40Z

Overview

As part of the Azure split work, a new Abstractions package is being created that contains types shared between MDS and its future extensions (Azure will be the first). This PR contains the YAML pipeline changes for CI and Official builds.

This supercedes the original PRs #3471 and #3567.

This depends on PR #3626.

Issues

The first step towards #1108.

Testing

Manual inspection of all artifacts produced by the pipelines.

paulmedynski · 2025-09-25T10:31:46Z

/azp run

azure-pipelines · 2025-09-25T10:31:51Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

codecov · 2025-09-25T14:01:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/azure-split@2843bdd). Learn more about missing BASE report.

Additional details and impacted files

@@                 Coverage Diff                 @@
##             feat/azure-split    #3628   +/-   ##
===================================================
  Coverage                    ?   90.82%           
===================================================
  Files                       ?        6           
  Lines                       ?      316           
  Branches                    ?        0           
===================================================
  Hits                        ?      287           
  Misses                      ?       29           
  Partials                    ?        0

Flag	Coverage Δ
addons	`90.82% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski

Commentary for reviewers, and some actions for myself.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

eng/pipelines/common/templates/jobs/ci-run-tests-job.yml

eng/pipelines/libraries/ci-build-variables.yml

eng/pipelines/libraries/common-variables.yml

eng/pipelines/steps/compound-build-akv-step.yml

eng/pipelines/steps/roslyn-analyzers-akv-step.yml

eng/pipelines/dotnet-sqlclient-ci-core.yml

paulmedynski · 2025-09-26T18:38:29Z

/azp run

azure-pipelines · 2025-09-26T18:38:36Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

paulmedynski · 2025-09-29T13:00:09Z

/azp run

azure-pipelines · 2025-09-29T13:00:27Z

Azure Pipelines successfully started running 1 pipeline(s).

paulmedynski · 2025-09-29T13:01:23Z

/azp run

azure-pipelines · 2025-09-29T13:01:40Z

Azure Pipelines successfully started running 2 pipeline(s).

paulmedynski

Commentary for reviewers.

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

eng/pipelines/common/templates/jobs/validate-signed-package-job.yml

eng/pipelines/common/templates/steps/ci-project-build-step.yml

eng/pipelines/common/templates/steps/copy-dlls-for-test-step.yml

build.proj

mdaigle

Overall, things look good to me. I think it would be helpful to have a walkthrough of a pipeline run to show us the different build artifacts, their version numbers, etc. so that we can see how it all fits together in the end.

eng/pipelines/common/templates/jobs/build-signed-package-job.yml

paulmedynski

Commentary for reviewers.

eng/pipelines/common/templates/steps/code-analyze-step.yml

eng/pipelines/jobs/build-akv-official-job.yml

eng/pipelines/steps/compound-build-akv-step.yml

- Removed addition of PDBs from <AllowedOutputExtensionsInPackageBuildOutputFolder>. - Removed MDS package ref dependency on Abstractions until pipelines are ready. - Renamed AbstractionsPackage to Abstractions in targets. - Updated BUILDGUIDE based on project ref behaviour. - Added feature branches to CI pipeline triggers. - Added missing/incomplete paths to the trigger. - Added dev/* branches to the CI triggers so PRs that target other dev/ branches can run CI. - Added missing MdsPackageVersion property to signed build pipeline job. - Commented-out failing NuGet tool installer task. - Re-ordered Guardian analysis step _before_ build step to avoid clobbering versioned DLLs. - Added MDS package version to AKV build/package steps. - Restored AKV nuspec ReferenceType property for AKV Official builds. - Explicitly building tooling before analysis. - Fixing validation steps to match XML props files. - Added PR automation triggers, and documented other pipeline sections. - Added ReferenceType throughout the MDS/AKV CI build steps. - Added NuGet.config update to main CI build step for Package reference mode. - Swapped Abstractions download and NuGet.config update to ensure packages/ exists before attempting to re-configure NuGet. - Clean target no longer removes packages/ - Uncommented package refs to Abstractions. - Added separate MDS and AKV project builds to support Package mode. - Added $ReferenceType$ property to MDS .nuspec like it is for AKV. - Removed obsolete version variables from merge conflict. - Added MDS package version to AKV official build steps for Package mode. - Moved Roslyn analysis above build steps to avoid Roslyn clobbering artifacts. - Removed obsolete code scanning.

- Made NuGet.config update pipeline step more robust.

paulmedynski

Tracking my own review progress.

mdaigle

One question. otherwise looks good

tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec

Abstractions Package - Pipeline Changes (#3628) Move AAD/Entra Authentication into new Azure package (#3680) User Story 39839: Move existing MDS tests to Azure package - Identified and moved tests specific to ActiveDirectoryAuthenticationProvider into the Azure Test project. - Updated some MDS tests that unnecessarily used ActiveDirectoryAuthenticationProvider. - Added tests to Abstractions Test project to ensure AAD/Entra auth fails when the Azure package isn't present. - Various build and pipeline changes to support the test changes. - Fixed project-based builds so we can restore MDS netcore and netfx projects at the same time. - Added caching to the managed identity provider for the ManualTest project. - Moved username/password Entra auth provider into its own file for sharing across tests. - Added ADO service connection for test tasks that require access to Azure resources. - Added workload identity federation tests. - Solved the mystery of SNI DLLs missing for .NET Framework project-reference-based builds. - Added ADO-CI-1ES pool jobs to test the Azure package on Linux and Windows. - Fixed Azure package pipelines to support pools in the ADO.Net and Public projects. - Added some new pipeline variables to handle the Workload Identity Federation test.

paulmedynski added this to the 7.0-preview2 milestone Sep 23, 2025

This was referenced Sep 23, 2025

Abstractions Package - C# project changes #3626

Merged

Create Abstractions package #3567

Closed

priyankatiwari08 self-assigned this Sep 23, 2025

paulmedynski force-pushed the dev/paul/azure-split/abstractions-code branch from 96b8487 to 383a354 Compare September 23, 2025 20:42

paulmedynski force-pushed the dev/paul/azure-split/abstractions-pipelines branch from b02a214 to 49ec317 Compare September 24, 2025 13:46

paulmedynski changed the title ~~[DRAFT] Abstractions Package - Pipeline Changes~~ Abstractions Package - Pipeline Changes Sep 25, 2025

paulmedynski marked this pull request as ready for review September 25, 2025 15:29

paulmedynski requested a review from a team as a code owner September 25, 2025 15:29

paulmedynski commented Sep 25, 2025

View reviewed changes

paulmedynski commented Sep 30, 2025

View reviewed changes

Base automatically changed from dev/paul/azure-split/abstractions-code to feat/azure-split September 30, 2025 18:11

paulmedynski force-pushed the dev/paul/azure-split/abstractions-pipelines branch 2 times, most recently from 75eb084 to 181aa0c Compare September 30, 2025 18:23

mdaigle self-assigned this Sep 30, 2025

mdaigle previously approved these changes Oct 1, 2025

View reviewed changes

eng/pipelines/common/templates/jobs/build-signed-package-job.yml Show resolved Hide resolved

paulmedynski dismissed mdaigle’s stale review via dc7ace3 October 2, 2025 10:36

paulmedynski modified the milestones: 7.0-preview2, 7.0.0-preview3 Oct 8, 2025

paulmedynski commented Oct 9, 2025

View reviewed changes

eng/pipelines/common/templates/steps/code-analyze-step.yml Show resolved Hide resolved

eng/pipelines/jobs/build-akv-official-job.yml Show resolved Hide resolved

eng/pipelines/steps/compound-build-akv-step.yml Show resolved Hide resolved

paulmedynski force-pushed the feat/azure-split branch from c96942d to 2843bdd Compare October 9, 2025 17:41

paulmedynski force-pushed the dev/paul/azure-split/abstractions-pipelines branch from 7d99049 to c02e97d Compare October 9, 2025 17:49

paulmedynski added 4 commits October 9, 2025 15:43

- Fixed old parameter name for AKV official pipeline.

1a081d6

- Added ReferenceType property to official MDS build step.

810df3e

- Added ReferenceType to MDS official build.

568f751

- Made NuGet.config update pipeline step more robust.

- Fixed typo in NuGet.config update template path.

1664dc0

paulmedynski commented Oct 9, 2025

View reviewed changes

samsharma2700 self-assigned this Oct 14, 2025

cheenamalhotra requested a review from a team October 15, 2025 18:32

mdaigle requested changes Oct 15, 2025

View reviewed changes

tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec Show resolved Hide resolved

cheenamalhotra approved these changes Oct 15, 2025

View reviewed changes

mdaigle approved these changes Oct 16, 2025

View reviewed changes

paulmedynski merged commit a60a025 into feat/azure-split Oct 16, 2025
260 checks passed

paulmedynski deleted the dev/paul/azure-split/abstractions-pipelines branch October 16, 2025 16:23

paulmedynski added a commit that referenced this pull request Oct 16, 2025

Abstractions Package - Pipeline Changes (#3628)

7f88ea6

paulmedynski added a commit that referenced this pull request Oct 20, 2025

Abstractions Package - Pipeline Changes (#3628)

c66066a

paulmedynski mentioned this pull request Oct 20, 2025

Move AAD/Entra Authentication into new Azure package #3680

Merged

paulmedynski added a commit that referenced this pull request Oct 23, 2025

Abstractions Package - Pipeline Changes (#3628)

287309f

paulmedynski added a commit that referenced this pull request Nov 17, 2025

Abstractions Package - Pipeline Changes (#3628)

6720b4a

Abstractions Package - Pipeline Changes #3628

Abstractions Package - Pipeline Changes #3628

Uh oh!

Conversation

paulmedynski commented Sep 23, 2025

Overview

Issues

Testing

Uh oh!

paulmedynski commented Sep 25, 2025

Uh oh!

azure-pipelines bot commented Sep 25, 2025

Uh oh!

codecov bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski commented Sep 26, 2025

Uh oh!

azure-pipelines bot commented Sep 26, 2025

Uh oh!

paulmedynski commented Sep 29, 2025

Uh oh!

azure-pipelines bot commented Sep 29, 2025

Uh oh!

paulmedynski commented Sep 29, 2025

Uh oh!

azure-pipelines bot commented Sep 29, 2025

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

mdaigle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Sep 25, 2025 •

edited

Loading