Skip to content

Conversation

@SimonCropp
Copy link
Contributor

  • Azure.Identity 1.12.0
  • Azure.Core 1.42.0
  • Azure.Security.KeyVault.Keys 4.6.0

@JRahnama
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.06%. Comparing base (321080e) to head (7f5b39c).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2808      +/-   ##
==========================================
- Coverage   72.06%   72.06%   -0.01%     
==========================================
  Files         299      299              
  Lines       61436    61436              
==========================================
- Hits        44275    44272       -3     
- Misses      17161    17164       +3     
Flag Coverage Δ
addons 92.90% <ø> (ø)
netcore 75.99% <ø> (+0.01%) ⬆️
netfx 70.24% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JRahnama
Copy link
Contributor

JRahnama commented Aug 25, 2024

I was wondering if we could apply the same approach to Azure.Core that @ErikEJ used for Microsoft.Identity.Client in PR #2577.

A minor concern would be Azure.Identity is referencing Azure.Core >=1.40.0 and we try to reference v1.42.0

@kf-gonzalez2 kf-gonzalez2 added this to the 6.0-preview2 milestone Aug 26, 2024
@DavoudEshtehari DavoudEshtehari added Code Health 💊 Issues/PRs that are targeted to source code quality improvements. Breaking Change 🔨 Issues/PRs that are related with breaking API changes in the driver. labels Aug 27, 2024
@cheenamalhotra
Copy link
Member

@DavoudEshtehari Since the version bumps are minor versions - can this be tagged as a non-breaking change? Unless you want to elaborate your understanding here?

@DavoudEshtehari DavoudEshtehari removed the Breaking Change 🔨 Issues/PRs that are related with breaking API changes in the driver. label Sep 17, 2024
@DavoudEshtehari
Copy link
Contributor

Thanks @cheenamalhotra, there was confusion due to a major version bump of a transient dependency affecting versions 4.0 and earlier, which does not apply here.

@cheenamalhotra
Copy link
Member

@SimonCropp

Please update as below (latest):

  • Azure.Identity v1.12.1
  • Azure.Core v1.44.0

@cheenamalhotra cheenamalhotra changed the title fix azure transitive CVEs Update Azure dependencies to latest stable versions Oct 9, 2024
@SimonCropp SimonCropp closed this Oct 9, 2024
@SimonCropp SimonCropp deleted the fix-azure-transtive-CVE branch October 9, 2024 06:59
@mdaigle mdaigle removed this from the 6.0-preview2 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Health 💊 Issues/PRs that are targeted to source code quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants