Skip to content

Conversation

@Perksey
Copy link
Member

@Perksey Perksey commented Jul 5, 2019

Summary of the PR

This proposal covers the following areas:

  • Silk.NET.Input
  • Silk.NET.Input.Common
  • Silk.NET.Input.Desktop
  • Silk.NET.Input.Mobile

Related issues, Discord discussions, or proposals

None.

Further Comments

None.

@Perksey Perksey added this to the 1.0 milestone Jul 5, 2019
@Perksey Perksey requested a review from a team July 5, 2019 12:33
@Perksey Perksey mentioned this pull request Jul 5, 2019
4 tasks
Copy link
Contributor

@Azyyyyyy Azyyyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two little additions to the proposal that could be nice to have

@Azyyyyyy
Copy link
Contributor

Azyyyyyy commented Jul 5, 2019

Umm would a D-Pad on a Gamepad be classed as 4 buttons because a Gamepad typically has a D-Pad?

@Perksey
Copy link
Member Author

Perksey commented Jul 5, 2019

In older versions of this proposal, I did have a DPad struct, but instead, I decided to ditch it in favour of the buttons as the same functionality can be replicated, but with less surface API. Plus, it makes it easier handling DPad buttons from the same place where you handle all your other buttons.

@Azyyyyyy
Copy link
Contributor

Azyyyyyy commented Jul 5, 2019

Ok, if someone really wanted it they could always make a extension. Got my approval.

Copy link
Contributor

@devvoid devvoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I'm curious about, otherwise this looks good to me.

@Perksey Perksey merged commit 9a1abf4 into dotnet:master Jul 5, 2019
@Perksey Perksey deleted the input-prop branch July 5, 2019 19:31
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
silkdotnet pushed a commit that referenced this pull request Mar 21, 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
silkdotnet pushed a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants