improve BaselineCustomAnalyzer warning message, fixes #2591 #2650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through #2591 and tried to improve the warning message here - taking a look at what code paths can cause this warning, I see that in
BaseLineCustomColumn.ResultsAreInvalid
it checks for whether the baseline / benchmark (or the results of) was null, and a check for!CanBeInverted
on the baseline which checks if it's too close to zero.First issue here, let me know if this analysis is right / what other changes I need to make before this can be merged. Thanks! :)