Skip to content

Conversation

znxftw
Copy link
Contributor

@znxftw znxftw commented Sep 26, 2024

Went through #2591 and tried to improve the warning message here - taking a look at what code paths can cause this warning, I see that in BaseLineCustomColumn.ResultsAreInvalid it checks for whether the baseline / benchmark (or the results of) was null, and a check for !CanBeInverted on the baseline which checks if it's too close to zero.

internal static bool ResultsAreInvalid(Summary summary, BenchmarkCase benchmarkCase, BenchmarkCase? baseline)
{
    return baseline == null ||
           summary[baseline] == null ||
           summary[baseline].ResultStatistics == null ||
           !summary[baseline].ResultStatistics.CanBeInverted() ||
           summary[benchmarkCase] == null ||
           summary[benchmarkCase].ResultStatistics == null;
}
 public bool CanBeInverted() => Min > 1e-9;

First issue here, let me know if this analysis is right / what other changes I need to make before this can be merged. Thanks! :)

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @znxftw!

@timcassell timcassell merged commit 6248e85 into dotnet:master Oct 20, 2024
8 checks passed
@timcassell timcassell added this to the v0.14.1 milestone Oct 20, 2024
@timcassell timcassell linked an issue Oct 20, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to compute the (Ratio, RatioSD)

2 participants