Skip to content

fix: Modify logging behavior when explicitly adding NullLogger with custom config #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Modify logging behavior when explicitly adding NullLogger with custom config #2594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BenchmarkDotNet/Configs/ConfigExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public static class ConfigExtensions
internal static ILogger GetNonNullCompositeLogger(this IConfig config)
{
// if user did not provide any loggers, we use the ConsoleLogger to somehow show the errors to the user
if (config == null || !config.GetLoggers().Any())
if (config == null || !config.GetLoggers().Any() || config.GetLoggers().All(x => x is NullLogger))
return new CompositeLogger(ImmutableHashSet.Create(ConsoleLogger.Default));

return new CompositeLogger(config.GetLoggers().ToImmutableHashSet());
Expand Down
Loading