-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Surface .dev.localhost TLD Visual Studio option #35952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment for you to look at.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@tdykstra ... It's done. This is just for the Blazor tutorials then, which don't have screenshots of VS for that bit. WRT the versioning aspects, I'll wait to hear from @danroth27 and @wadepickett before proceeding. |
BTW @tdykstra @wadepickett ... I already messaged Cassie about this but received no response. Would you consider seeing if they'll 🛑 the constant PoliCheck Scan Report comments when the scan passes? It's generating a lot of unnecessary comment churn and email pings. |
There was a discussion on this that was going on and still active this morning. I think as of this morning it may not have been resolved yet but stakeholders understand the problem and they may be close to changing it for the better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Dan ... if you see this ... I don't need to bother you with this one after all, so I removed your review ping. I'm only going to call out the .dev.localhost TLD VS setting on the two Blazor tutorials. |
Fixes #35936
I should hear back from all before merging, as there's an editorial decision to be made on this one.
Changes
This is only for empty (
web
) and BWA (blazor
) template-based app creation per Damian's remarks ...Tooling guidance generally isn't versioned
We usually don't version VS tooling guidance. We assume that the dev is using the latest tooling and the latest project templates for our tutorials. This updates our guidance to include coverage for the new "Use the .dev.localhost TLD in the application URL" option. I made the update across the repo, using whatever styling the doc author had in place without versioning.
However, this is a project template-based setting. Therefore, it's really only going to appear for >=10.0 project template-created apps. I lean in the direction of just going ahead with the updates unversioned as they appear on the PR. Most apps are created for late-model releases, right? ... with late-model VS, right? If we can avoid versioning for tooling instructions, it's best.
Internal previews