Skip to content

Initial URL for BlazorWebView #28968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Initial URL for BlazorWebView #28968

merged 1 commit into from
Apr 18, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Apr 13, 2023

Fixes #28965

cc: @mkArtakMSFT ... I can see that Surayya did the PR ... I'll ping for review.

Notes:

  • Do we want to use this language to describe the default start path? ...

    The default start path is the relative root URL path (/).

    ... because I'm not aware if it's possible for these apps to have a different base path. I'll modify to your best choice of language there.

  • Just FYI ... Across the Hybrid docs, we use the approach for setting properties on a BlazorWebView that the tutorials adopt. In the case where the dev is looking at the XAML markup code, we show the setting on the element, not via the designer property tools. In the WinForms case, we set those properties in C#, so that's what we place here. We assume the reader used our tutorials, so we assume they'll work with the properties across the docs the same way as the tutorials have them work with them. Just letting you know. This is subject to change later perhaps, but this is the approach we're using thus far.

@guardrex guardrex requested a review from surayya-MS April 13, 2023 15:31
@guardrex guardrex self-assigned this Apr 14, 2023
Copy link
Member

@surayya-MS surayya-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@guardrex guardrex requested a review from danroth27 April 14, 2023 12:27
@surayya-MS
Copy link
Member

Do we want to use this language to describe the default start path? ...
The default start path is the relative root URL path (/).
... because I'm not aware if it's possible for these apps to have a different base path. I'll modify to your best choice of language there.

This language looks good to me. @Eilon , what do you think?

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guardrex
Copy link
Collaborator Author

Shall we wait on @Eilon to look at that phrasing before merging?

Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think this is fine, thanks for checking. If for some reason we ever see in the future that it is unclear to someone, we can revisit, but I'd be surprised.

@guardrex guardrex merged commit 5de2c96 into main Apr 18, 2023
@guardrex guardrex deleted the guardrex-patch-1 branch April 18, 2023 17:16
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify initial URL for BlazorWebView to load
4 participants