Skip to content

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Mar 10, 2023

Fixes #27156

The http-ports.md include file was added in an earlier PR, so to see all of it expand the diff manually or use the Kestrel endpoints internal preview or HTTP.sys internal preview.

@Tratcher

This would also work with Http.Sys though we have a warning there not to use wildcards.

It looks awkward to have text explaining how to conveniently specify ports-only right next to a warning not to use wildcards for URLs. Is there something we should say to make it look less like we're contradicting ourselves?

Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/servers/httpsys.md aspnetcore/fundamentals/servers/httpsys
aspnetcore/fundamentals/servers/kestrel/endpoints.md aspnetcore/fundamentals/servers/kestrel/endpoints

Additional internal review URL, for minimal API quick reference, WebApplication section.

@tdykstra tdykstra marked this pull request as ready for review March 14, 2023 00:07
@tdykstra tdykstra requested a review from Tratcher March 14, 2023 00:07
@Tratcher
Copy link
Member

It looks awkward to have text explaining how to conveniently specify ports-only right next to a warning not to use wildcards for URLs. Is there something we should say to make it look less like we're contradicting ourselves?

How about saying this is convenient for development and container scenarios, but avoid wildcards when potentially running on a machine with other services.

@tdykstra tdykstra requested a review from Rick-Anderson March 16, 2023 18:46
@tdykstra tdykstra merged commit 9b8ca04 into dotnet:main Mar 16, 2023
@tdykstra tdykstra deleted the httpports3 branch March 16, 2023 19:35
Donciavas pushed a commit to Donciavas/AspNetCore.Docs that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc HTTP_PORTS, HTTPS_PORTS

3 participants